Fix bug in 2D plotting. #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug was caused when both data and WCS were 2D. In this case a slice list was being called, even though that list was only created when the data was 2D with a >2D WCS with missing axes.
|
Thanks for the pull request @DanRyanIrish! Everything looks great! |
|
Another potential bug though. The axis on this plot are clearly arcsec but then it says deg on the axis labels. |
|
Thanks for pointing out that bug @ehsteve. It's unclear whether this is a bug in I'll raise an issue and deal with it in separate PR as it's not an obvious fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug was caused when both data and WCS were 2D. In this case a slice list
was being called, even though that list was only created when the data
was 2D with a >2D WCS with missing axes.
Description
The bug is fixed by only entering the
slice_listto thegca_wcsmethod if thewcsis greater than 2 when the data is 2D.Fixes #