Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helpful error when unsupported slice item used. #158

Merged
merged 1 commit into from
May 8, 2019

Conversation

DanRyanIrish
Copy link
Member

Description

Fixes #128

@DanRyanIrish DanRyanIrish requested a review from Cadair April 12, 2019 17:15
@DanRyanIrish
Copy link
Member Author

@Cadair is this error more helpful?

@DanRyanIrish DanRyanIrish added this to the 1.1.2 milestone May 8, 2019
@ghost
Copy link

ghost commented May 8, 2019

Thanks for the pull request @DanRyanIrish!

I am a bot that checks pull requests for milestones and changelog entries. If you have any questions about what I am saying, please ask!
I have the following to report on this pull request:

  • I didn't detect a changelog file in this pull request. Please add a changelog file to the changelog/ directory following the instructions in the changelog README.

If there are any issues with this message, please report them here.

@DanRyanIrish DanRyanIrish merged commit bb7e125 into sunpy:master May 8, 2019
DanRyanIrish added a commit to DanRyanIrish/ndcube that referenced this pull request May 8, 2019
DanRyanIrish added a commit to DanRyanIrish/ndcube that referenced this pull request May 8, 2019
DanRyanIrish added a commit that referenced this pull request May 8, 2019
DanRyanIrish added a commit that referenced this pull request May 8, 2019
Add helpful error when unsupported slice item used.
DanRyanIrish added a commit that referenced this pull request May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slicing an NDCube with either a list or an array fails with an unhelpful error
2 participants