-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NDCube Plot Enhancements #106
Merged
DanRyanIrish
merged 18 commits into
sunpy:master
from
DanRyanIrish:ndcube_plot_enhancements
Apr 30, 2018
Merged
NDCube Plot Enhancements #106
DanRyanIrish
merged 18 commits into
sunpy:master
from
DanRyanIrish:ndcube_plot_enhancements
Apr 30, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… plot helper function.
… and masks and give default labels.
… and masks and give default labels.
…plot_enhancements
…t working apparently because of a glitch in ImageAnimatorWCS.
…e plath for future 1D animation functionality.
…e function so it can be used elsewhere. Minor bug found as part of process that was fixed.
…D animation method. Currently doesnt work though, probably due to bugs in sunpy ImageAnimator.
…datetimes and removed kwargs not accepted currently when calling ImageAnimator.
DanRyanIrish
force-pushed
the
ndcube_plot_enhancements
branch
from
March 31, 2018 04:19
a8f0ca8
to
a48106e
Compare
…plot_enhancements
…plot_enhancements
Hello @DanRyanIrish! Thanks for updating the PR.
Comment last updated on April 28, 2018 at 15:38 Hours UTC |
DanRyanIrish
force-pushed
the
ndcube_plot_enhancements
branch
2 times, most recently
from
April 9, 2018 15:24
6f2746a
to
0a7a81d
Compare
…plot_enhancements
…plot_enhancements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses deficiencies raised in Issue #102