Separate plotting from NDCube base class #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Rename current NDCubeBase to NDCubeABC and create new NDCube class which mixes in the base and plotting mixin.
DanRyanIrish
added a commit
to DanRyanIrish/ndcube
that referenced
this pull request
Mar 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a new
NDCubeBaseclass that contains all theNDCubefunctionality except plotting. This allows custom plotting mixin classes to be used withNDCubeand stops the basic version ofNDCubebeing dependent onsunpy. This was achieved by doing the following:NDCubeBasetoNDCubeABCNDCubeclass toNDCubeBaseand remove theNDCubePlotMixinandastropy.nddata.NDArithmeticMixinmixin classes from its inheritence.NDCubeclass which inherits from newNDCubeBaseand theNDCubePlotMixinandastropy.nddata.NDArithmeticMixinmixin classes.