Fix crashing bug when slicing NDCube.

If an axis after the first axis was sliced with a non-native int type, e.g. numpy.int64, the slixing would crash due to missing_axes not being altered. This commit adds support for nupy.int64 and numpy.int32 types.
sunpy · Dec 16, 2019 · 85eb2c2 · 85eb2c2
1 parent 37d2db2
commit 85eb2c2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/changelog/223.bugfix.rst b/changelog/223.bugfix.rst
@@ -0,0 +1 @@
+Fix crashing bug when an NDCube axis after the first is sliced with a numpy.int64.
diff --git a/ndcube/utils/wcs.py b/ndcube/utils/wcs.py
@@ -207,7 +207,7 @@ def _wcs_slicer(wcs, missing_axes, item):
             item_ = _slice_list(item_checked)
             new_wcs = wcs.slice(item_)
             for i, it in enumerate(item_checked):
-                if isinstance(it, int):
+                if isinstance(it, (int, np.int64, np.int32)):
                     missing_axes[i] = True
     else:
         raise NotImplementedError("Slicing FITS-WCS by {} not supported.".format(type(item)))
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix crashing bug when an NDCube axis after the first is sliced with a numpy.int64.