added: new variable to be able to disable the default behavior of wrapping draggable elements #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunpietro
requested changes
Nov 24, 2016
| elements.forEach(function (draggableElement) { | ||
| var wrapper = createElementWrapper(), | ||
| draggableParent = draggableElement.parentNode; | ||
| if (finalParams.wrapDraggableElements === TRUE) { |
There was a problem hiding this comment.
I would do it a different way.
wrapDraggableElements = function (elements) {
if (finalParams.wrapDraggableElements === FALSE) {
return FALSE;
}
elements.forEach(function (draggableElement) {
var wrapper = createElementWrapper(),
draggableParent = draggableElement.parentNode;
if (draggableParent.classList.contains(CLASS_DRAGGABLE)) {
return FALSE;
}
draggableParent.insertBefore(wrapper, draggableElement);
draggableParent.removeChild(draggableElement);
wrapper.appendChild(draggableElement);
});
};
It avoids the indentation of huge block of code.
|
Made the requested changes. |
sunpietro
reviewed
Nov 24, 2016
| @@ -201,6 +202,17 @@ | |||
| * @return {Array} | |||
| */ | |||
| wrapDraggableElements = function (elements) { | |||
| if (finalParams.wrapDraggableElements === TRUE) { | |||
There was a problem hiding this comment.
finalParams.wrapDraggableElements === FALSE
There was a problem hiding this comment.
OMG .. my bad .. sry
|
Fixed |
|
@Webtrix can you squash the commits into the one named: |
…pping draggable elements added: new variable to be able to disable the default behavior of wrapping draggable elements added: new variable to be able to disable the default behavior of wrapping draggable elements added: new variable to be able to disable the default behavior of wrapping draggable elements updated: made requested changes to PR fixed: typo TRUE --> FALSE typo: draggster --> dragster
|
Took me some searching but this OK? |
sunpietro
approved these changes
Nov 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being able to disable this default behavior might come useful for some people (myself included). I'm using your script in an Angular 2 project, and I need to disable this feature to get everything working correctly.
So would be cool if we could add this feature if possible.