Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modular Assistive Driving System (MADS) #40

Merged
merged 109 commits into from
Dec 6, 2024
Merged

Modular Assistive Driving System (MADS) #40

merged 109 commits into from
Dec 6, 2024

Commits on Sep 18, 2024

  1. alternative experience

    sunnyhaibin committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    b23543d View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. safety init

    sunnyhaibin committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    035c78a View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. fix

    sunnyhaibin committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    c3b7f82 View commit details
    Browse the repository at this point in the history
  2. more update

    sunnyhaibin committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    dcd226d View commit details
    Browse the repository at this point in the history
  3. not really

    sunnyhaibin committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    4f40ae6 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'master' into mads-new

    # Conflicts:
    #	board/safety.h
    #	board/safety/safety_hyundai.h
    #	board/safety_declarations.h
    sunnyhaibin committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    5aaa664 View commit details
    Browse the repository at this point in the history
  5. misra

    sunnyhaibin committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    546f43f View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Configuration menu
    Copy the full SHA
    1ac593f View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2024

  1. Configuration menu
    Copy the full SHA
    e46d040 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. Configuration menu
    Copy the full SHA
    9c62b7f View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Configuration menu
    Copy the full SHA
    80f23ae View commit details
    Browse the repository at this point in the history
  2. revert

    sunnyhaibin committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    d0653fb View commit details
    Browse the repository at this point in the history
  3. alt -> lkas

    sunnyhaibin committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    d843088 View commit details
    Browse the repository at this point in the history
  4. explicit checks

    sunnyhaibin committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    d379604 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. support toyota and ford

    sunnyhaibin committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    de6dae9 View commit details
    Browse the repository at this point in the history
  2. rename

    sunnyhaibin committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    6e3a70c View commit details
    Browse the repository at this point in the history
  3. hyundai can-fd support

    sunnyhaibin committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    6c974d9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    eb7a332 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Configuration menu
    Copy the full SHA
    7508579 View commit details
    Browse the repository at this point in the history
  2. revert

    sunnyhaibin committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    48b177f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f5807bc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    efc5c74 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1ae97c1 View commit details
    Browse the repository at this point in the history
  6. fix panda safety

    sunnyhaibin committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    d9f6815 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Configuration menu
    Copy the full SHA
    63946db View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. Merge branch 'master-new' into mads-new

    # Conflicts:
    #	python/__init__.py
    sunnyhaibin committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    4213170 View commit details
    Browse the repository at this point in the history
  2. ford btn

    sunnyhaibin committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    ad4bf6e View commit details
    Browse the repository at this point in the history
  3. toyota btn

    sunnyhaibin committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    21b7a72 View commit details
    Browse the repository at this point in the history
  4. fca btn

    sunnyhaibin committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    d99d410 View commit details
    Browse the repository at this point in the history
  5. honda btn

    sunnyhaibin committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    543864b View commit details
    Browse the repository at this point in the history
  6. mads safety tests

    sunnyhaibin committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    b909db9 View commit details
    Browse the repository at this point in the history
  7. more tests

    sunnyhaibin committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    dee9afc View commit details
    Browse the repository at this point in the history
  8. safety misra

    sunnyhaibin committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    4c33dca View commit details
    Browse the repository at this point in the history
  9. safety mutation

    sunnyhaibin committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    c3de776 View commit details
    Browse the repository at this point in the history
  10. misra

    sunnyhaibin committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    bdbb674 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2024

  1. mutation experiment

    sunnyhaibin committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    9fc1f6f View commit details
    Browse the repository at this point in the history
  2. fix

    sunnyhaibin committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    688024f View commit details
    Browse the repository at this point in the history
  3. ford test main button

    sunnyhaibin committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    0de4310 View commit details
    Browse the repository at this point in the history
  4. ford test lkas button

    sunnyhaibin committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    a5f7f47 View commit details
    Browse the repository at this point in the history
  5. more ford test

    sunnyhaibin committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    a910d33 View commit details
    Browse the repository at this point in the history
  6. hyundai lkas and main

    sunnyhaibin committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    b54d020 View commit details
    Browse the repository at this point in the history
  7. more ford

    sunnyhaibin committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    a53240e View commit details
    Browse the repository at this point in the history
  8. hyundai canfd

    sunnyhaibin committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    43ed51a View commit details
    Browse the repository at this point in the history
  9. rename

    sunnyhaibin committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    c55138c View commit details
    Browse the repository at this point in the history
  10. rename

    sunnyhaibin committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    1c30859 View commit details
    Browse the repository at this point in the history
  11. cleaner

    sunnyhaibin committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    218ffe4 View commit details
    Browse the repository at this point in the history
  12. more fixes

    sunnyhaibin committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    79953cb View commit details
    Browse the repository at this point in the history
  13. more hyundai tests

    sunnyhaibin committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    3b1ebab View commit details
    Browse the repository at this point in the history
  14. no longer needed

    sunnyhaibin committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    6b03941 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    b0ac850 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. thanks for tests!

    sunnyhaibin committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    a033911 View commit details
    Browse the repository at this point in the history
  2. more tests for lat

    sunnyhaibin committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    79ff2b0 View commit details
    Browse the repository at this point in the history
  3. more explicit

    sunnyhaibin committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    9d8d880 View commit details
    Browse the repository at this point in the history
  4. make sure to reset

    sunnyhaibin committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    3f2df0e View commit details
    Browse the repository at this point in the history
  5. try this out

    sunnyhaibin committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    a0ea527 View commit details
    Browse the repository at this point in the history
  6. probably needed

    sunnyhaibin committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    6e5e967 View commit details
    Browse the repository at this point in the history
  7. move

    sunnyhaibin committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    7d9218f View commit details
    Browse the repository at this point in the history
  8. misra

    sunnyhaibin committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    bf702b0 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. not needed

    sunnyhaibin committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    486ddd0 View commit details
    Browse the repository at this point in the history
  2. move to safety_mads

    sunnyhaibin committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    c0c1cc2 View commit details
    Browse the repository at this point in the history
  3. not really needed

    sunnyhaibin committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    3456b80 View commit details
    Browse the repository at this point in the history
  4. remove

    sunnyhaibin committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    d25cb1d View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2024

  1. MADS: Refactor MADS safety with improved state management (pull request

    #46)
    
    Refactor MADS safety with improved state management
    
    This commit introduces a major refactoring of the MADS safety module, improving state management and control flow. Key changes include:
    
    Core Changes:
    - Introduced a MADSState struct to centralize state management
    - Removed global state variables in favor of structured state
    - Implemented button transition handling with explicit state tracking (PRESSED/RELEASED/NO_CHANGE)
    - Added state flags for button availability detection
    - Simplified lateral control permission logic
    
    Button Handling:
    - Separated main button and LKAS button state tracking
    - Added independent engagement states for each button
    - Improved button press detection across multiple platforms
    - Added support for main and LKAS buttons on Hyundai platforms
    - Modified ACC main state handling
    
    Testing:
    - Added comprehensive test coverage for MADS state transitions
    - Added new MADS-specific test base class for consistent testing across platforms
    - Added mutation testing for state management
    - Extended timeout for mutation tests from 5 to 8 minutes
    - Added extensive button press validation tests
    - Enhanced debugging output in replay drive tests
    
    The refactored code provides a more organized implementation of MADS safety features while maintaining compatibility with existing safety checks.
    devtekve authored Dec 3, 2024
    Configuration menu
    Copy the full SHA
    01e8e55 View commit details
    Browse the repository at this point in the history
  2. adding note

    devtekve committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    a541089 View commit details
    Browse the repository at this point in the history
  3. adding ford (WIP)

    devtekve committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    86f5205 View commit details
    Browse the repository at this point in the history
  4. adding honda (WIP)

    devtekve committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    306470a View commit details
    Browse the repository at this point in the history
  5. adding toyota (WIP)

    devtekve committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    db0a822 View commit details
    Browse the repository at this point in the history
  6. adding chrysler (WIP)

    devtekve committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    cbb9ced View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2024

  1. Standardize Button State Handling Across Platforms

    Refactor button state handling by replacing integer constants with an enumerated `ButtonState` type and updating logic to improve readability and maintainability. This change affects button press detection in Ford, Honda, Hyundai, and Toyota safety modules and aligns them with a unified MADS button state approach. Enums provide a clearer understanding of button states and transitions, facilitating easier maintenance and future enhancements.
    devtekve committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    125763b View commit details
    Browse the repository at this point in the history
  2. Disable LKAS button press logic in Honda and Toyota safety.

    The code for processing LKAS button presses has been commented out in both Honda and Toyota safety implementations. This change aims to investigate or temporarily halt the button press effects without removing the logic altogether. It will be important to test for any impacts this may have on vehicle control functionality.
    devtekve committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    268c761 View commit details
    Browse the repository at this point in the history
  3. Remove commented out code in toyota_rx_hook function

    This commit cleans up the toyota_rx_hook function by removing unnecessary commented-out code that checks for LKAS button presses on bus 2. This helps improve code readability and maintainability without altering the existing functionality.
    devtekve committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    d6b012c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8223823 View commit details
    Browse the repository at this point in the history
  5. Honda LKAS

    sunnyhaibin committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    df85110 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b6a51d8 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f10b3e2 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2024

  1. nissan fix

    sunnyhaibin committed Dec 5, 2024
    Configuration menu
    Copy the full SHA
    b548ac2 View commit details
    Browse the repository at this point in the history
  2. gm fix

    sunnyhaibin committed Dec 5, 2024
    Configuration menu
    Copy the full SHA
    3f22376 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7974170 View commit details
    Browse the repository at this point in the history
  4. im bored

    sunnyhaibin committed Dec 5, 2024
    Configuration menu
    Copy the full SHA
    f2136d4 View commit details
    Browse the repository at this point in the history
  5. misra

    sunnyhaibin committed Dec 5, 2024
    Configuration menu
    Copy the full SHA
    b0b4cff View commit details
    Browse the repository at this point in the history
  6. subaru/toyota/honda

    sunnyhaibin committed Dec 5, 2024
    Configuration menu
    Copy the full SHA
    4c8566a View commit details
    Browse the repository at this point in the history
  7. nope

    sunnyhaibin committed Dec 5, 2024
    Configuration menu
    Copy the full SHA
    af86789 View commit details
    Browse the repository at this point in the history
  8. attempt

    sunnyhaibin committed Dec 5, 2024
    Configuration menu
    Copy the full SHA
    fc2c55c View commit details
    Browse the repository at this point in the history
  9. go through all buttons

    sunnyhaibin committed Dec 5, 2024
    Configuration menu
    Copy the full SHA
    87639db View commit details
    Browse the repository at this point in the history
  10. try nissan

    sunnyhaibin committed Dec 5, 2024
    Configuration menu
    Copy the full SHA
    649298e View commit details
    Browse the repository at this point in the history
  11. more nissan

    sunnyhaibin committed Dec 5, 2024
    Configuration menu
    Copy the full SHA
    b3cbf0c View commit details
    Browse the repository at this point in the history
  12. nissan tests passed!

    sunnyhaibin committed Dec 5, 2024
    Configuration menu
    Copy the full SHA
    5c8109e View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    6ae1254 View commit details
    Browse the repository at this point in the history
  14. Improved code organization in safety_subaru.h and test_subaru.py

    This commit includes a minor restructuring in safety_subaru.h and test_subaru.py for better readability and flow. The condition check in safety_subaru.h for lkas_hud now has explicit parentheses. With regard to test_subaru.py, an unnecessary import was removed, and the sequence of steps in the test was reordered - now enabling mads and cleaning up mads_states happens before each subtest.
    devtekve committed Dec 5, 2024
    Configuration menu
    Copy the full SHA
    e5a2cff View commit details
    Browse the repository at this point in the history
  15. Refactor tests to use _speed_msg instead of _user_brake_msg.

    Updated the MADS safety tests to utilize the _speed_msg(0) function call in place of _user_brake_msg(False).
    devtekve committed Dec 5, 2024
    Configuration menu
    Copy the full SHA
    e71f084 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    bf1ca4a View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    efe4a7e View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    90ca5a8 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    9b91dd5 View commit details
    Browse the repository at this point in the history
  20. Redoing more tests

    devtekve committed Dec 5, 2024
    Configuration menu
    Copy the full SHA
    24ee2e9 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    1aba730 View commit details
    Browse the repository at this point in the history
  22. Updating tests for toyota

    devtekve committed Dec 5, 2024
    Configuration menu
    Copy the full SHA
    34786d9 View commit details
    Browse the repository at this point in the history
  23. cleaning up tests on hkg

    devtekve committed Dec 5, 2024
    Configuration menu
    Copy the full SHA
    ec5b129 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    f31b815 View commit details
    Browse the repository at this point in the history
  25. revert

    sunnyhaibin committed Dec 5, 2024
    Configuration menu
    Copy the full SHA
    ae375f9 View commit details
    Browse the repository at this point in the history
  26. constants

    sunnyhaibin committed Dec 5, 2024
    Configuration menu
    Copy the full SHA
    af0fa54 View commit details
    Browse the repository at this point in the history
  27. cleanup

    sunnyhaibin committed Dec 5, 2024
    Configuration menu
    Copy the full SHA
    7851ac9 View commit details
    Browse the repository at this point in the history
  28. format!

    sunnyhaibin committed Dec 5, 2024
    Configuration menu
    Copy the full SHA
    4026ece View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    df2452f View commit details
    Browse the repository at this point in the history
  30. match yota

    sunnyhaibin committed Dec 5, 2024
    Configuration menu
    Copy the full SHA
    4ed88ad View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    9ec1b66 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2024

  1. force

    sunnyhaibin committed Dec 6, 2024
    Configuration menu
    Copy the full SHA
    c62a1b2 View commit details
    Browse the repository at this point in the history
  2. explicit checks

    sunnyhaibin committed Dec 6, 2024
    Configuration menu
    Copy the full SHA
    1872a7b View commit details
    Browse the repository at this point in the history
  3. revert

    sunnyhaibin committed Dec 6, 2024
    Configuration menu
    Copy the full SHA
    c07a279 View commit details
    Browse the repository at this point in the history