-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generate context name by specific attributes #956
Conversation
Signed-off-by: chengzw <[email protected]>
The Label Bot has predicted the following:
|
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
4387263 | Triggered | Generic High Entropy Secret | 331be08 | cmd/add_test.go | View secret |
4387264 | Triggered | Generic High Entropy Secret | 331be08 | cmd/add_test.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #956 +/- ##
==========================================
+ Coverage 19.40% 19.65% +0.24%
==========================================
Files 21 21
Lines 2077 2122 +45
==========================================
+ Hits 403 417 +14
- Misses 1630 1661 +31
Partials 44 44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0bdc035
to
c302e3c
Compare
Signed-off-by: chengzw <[email protected]>
c302e3c
to
a5b72b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, just need to add some unit tests!
Signed-off-by: chengzw <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's close to perfect, please update the Chinese documentation: zh-cn/cli/kubecm_merge.md
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for your valuable contribution to this project! Your work is greatly appreciated. 🎆
Description
Use two kubeconfig files for testing.
Case 1: Use the default context-template value ("context")
The context name is the same as the original kubeconfig.
Case 2: Define context template
Case 3: Define context template and context prefix
Case 4: kubecm merge with context template
Case 5: Define context name
it's useful if there is only one context in the kubeconfig file.
If the kubeconfig file contains more than 1 context, an incremental number will be added as a suffix.
Related Issue
resolves #768
Type of Change
Checklist
make build
andmake test
commands.make doc-gen
to generate new documentation.