Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump github.com/savioxavier/termlink from 1.2.1 to 1.3.0 #726

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 3, 2023

Bumps github.com/savioxavier/termlink from 1.2.1 to 1.3.0.

Release notes

Sourced from github.com/savioxavier/termlink's releases.

v1.3.0

Note Remaking this because Go's semver is completely different This was originally v2.0.0 but apparently Go accepts only v0 or v1 Either ways, a complete v2 package (with a v2/ directory) is not required as this fixes issues, mostly, not change the API

Information

  • Release of termlink with a few breaking changes in the form of version parsing fixes

Hyperlink detection

  • Hyperlink detection has been greatly improved
  • New variables and variable checks have been introduced
  • TERM_PROGRAM variable checking is stricter now, with the help of TERM_PROGRAM_VERSION constraints. This is a breaking change
  • Multiple handling functions for environment variable detection such as hasEnv, checkAllEnvs, matchesEnv etc., have been added
  • Version handling is now in a form of a struct called Version. parseVersion now returns this struct of three variables instead of three standalone variables called major, minor, and patch
  • Version scanning now works with version that don't even contain dots
  • os.Getenv() has been replaced with os.LookupEnv()
  • termlink now respects the FORCE_HYPERLINK variable, and forces hyperlinks as long as the variable's value is any of []string{"1", "true", "always", "enabled"}
  • Added support for more terminals including vscode and alacritty (possibly fixes #7)
  • Added support for COLORTERM variable
  • Fixed incorrect version condition for VTE_VERSION

Color Handling

  • colorsList map now has integer keys instead of strings
  • Keys have been arranged according to their ANSI escape code
  • Detecting and adding valid colors from a termlink style color string has been refactored and simplified
  • Colors are initially cleared upon entry to avoid redundant color codes
  • parseColor("reset") has been replaced with an escape code to avoid additional processing

Dependencies

  • fatih/color and jwalton/go-supportscolor have both been removed from the project. Checking for color support is unnecessary because this package only requires checking for basic colors. fatih/color wasn't used in the main termlink code anyways
  • Currently, this package is dependency-free
  • The only dependency is the assert testing library, which is only used for testing purposes and has no effect on main

Documentation

  • godoc comments have been improved
  • README.md has been modified with more code snippets and examples for other utilities such as SupportsHyperlinks and shouldForce

Examples

  • examples/start.go has been improved with more examples and texts

Tests

... (truncated)

Commits
  • 3afa4f8 Merge pull request #8 from savioxavier/rewrite
  • 710c88f docs(readme): add github-native note
  • 40e54d6 docs(readme): cleanup
  • c7cb4a2 docs(readme): add code snippet for the optional shouldForce argument
  • 4d4fc6e docs(readme): add SupportsHyperlinks code snippet
  • b8cc382 docs(readme): update quickstart
  • 93b7dcf docs(readme): update attributions
  • 4044761 fix: refactor color handling algorithm
  • 2cd732c chore(example): print goodbye message
  • 2ccc2d8 chore: add comments about WezTerm versioning and Hyper incompatibility
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/savioxavier/termlink](https://github.com/savioxavier/termlink) from 1.2.1 to 1.3.0.
- [Release notes](https://github.com/savioxavier/termlink/releases)
- [Commits](savioxavier/termlink@v1.2.1...v1.3.0)

---
updated-dependencies:
- dependency-name: github.com/savioxavier/termlink
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jul 3, 2023
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #726 (4dd3f7c) into master (1549f02) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #726   +/-   ##
=======================================
  Coverage   19.52%   19.52%           
=======================================
  Files          20       20           
  Lines        2090     2090           
=======================================
  Hits          408      408           
  Misses       1643     1643           
  Partials       39       39           
Flag Coverage Δ
unittests 19.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Owner

@sunny0826 sunny0826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for your contribution 🎆

@sunny0826 sunny0826 merged commit bfd26f7 into master Jul 4, 2023
@sunny0826 sunny0826 deleted the dependabot/go_modules/github.com/savioxavier/termlink-1.3.0 branch July 4, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant