Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Params #42

Closed
wycats opened this issue Oct 2, 2015 · 3 comments
Closed

Block Params #42

wycats opened this issue Oct 2, 2015 · 3 comments
Labels
enhancement help wanted syntax

Comments

@wycats
Copy link

wycats commented Oct 2, 2015

Any plans to add support for Handlebars block params?
@sunng87
Copy link
Owner

sunng87 commented Oct 2, 2015

Wow, @wycats, thanks for analyzing this library.
I didn't know this block param feature before. I will add support in future releases.

https://github.com/emberjs/rfcs/blob/master/text/0003-block-params.md

@sunng87 sunng87 added the syntax label Feb 24, 2016
@mmun
Copy link

mmun commented Aug 9, 2016 •
edited
Loading

I would encourage anyone who is interested and has the time to make an attempt to implement this feature. Block params are an important part of the handlebars language! Let me know if you need details on the semantics beyond what is described in the document linked above.

sunng87 added a commit that referenced this issue Sep 4, 2016
@sunng87
(feat) added grammar for block params [#42]
7053f81 
Signed-off-by: Ning Sun <[email protected]>
@sunng87 sunng87 mentioned this issue Sep 4, 2016
Merged
5 tasks
sunng87 added a commit that referenced this issue Sep 6, 2016
@sunng87
(feat) added template parser support for block param [#42]
c22472b 
Signed-off-by: Ning Sun <[email protected]>
sunng87 added a commit that referenced this issue Sep 7, 2016
@sunng87
(feat) refactor render context [#42]
453bfa0 
Signed-off-by: Ning Sun <[email protected]>
sunng87 added a commit that referenced this issue Sep 9, 2016
@sunng87
(feat) added block param for each [#42]
02408ec 
Signed-off-by: Ning Sun <[email protected]>
sunng87 added a commit that referenced this issue Sep 9, 2016
@sunng87
(feat) block params for each block [#42]
5b95186 
Signed-off-by: Ning Sun <[email protected]>
sunng87 added a commit that referenced this issue Sep 10, 2016
@sunng87
(feat) block param for with [#42]
3e359ff 
Signed-off-by: Ning Sun <[email protected]>
@sunng87
Copy link
Owner

sunng87 commented Sep 10, 2016

This has landed to master via #101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wycats @sunng87 @mmun