Install script fixes for better Mac support

[richwrightnyc]

Trying to install on Mac and encountered a bug. At line 18, sha256sum was throwing an error because that command has a different syntax on Macs.

Verifiying checksum...
Error: ./support/scripts/install: line 18: sha256sum: command not found

Fixed this by adding additional logic for checksum validation if uname -s returns "Darwin"

Created an array for supported system types, for better readability and future extensibility.

[sundowndev]

Thanks for your PR @HudsonOnHere 👍🏻

However I don't think that's a great way of handling this. Verifying checksum is optional and sha256sum could be missing on other platforms too (assuming this script can evolve at any time to support more platforms). Instead, I would suggest we simply skip checksum verification and display a warning message such as "WARNING: checksum verification was skipped because sha256sum is not installed."

EDIT: another solution could be to check whever sha256sum or shasum is installed and use one of them, without checking the platform. If none is installed, exit with error.

WDYT?

[sundowndev]

Eventually, this PR could fix #1202 as well. I think we can drop usage of wget and use curl for all requests.

[richwrightnyc]

Thanks for your PR @HudsonOnHere 👍🏻

However I don't think that's a great way of handling this. Verifying checksum is optional and sha256sum could be missing on other platforms too (assuming this script can evolve at any time to support more platforms). Instead, I would suggest we simply skip checksum verification and display a warning message such as "WARNING: checksum verification was skipped because sha256sum is not installed."

EDIT: another solution could be to check whever sha256sum or shasum is installed and use one of them, without checking the platform. If none is installed, exit with error.

WDYT?

@sundowndev Thanks for your feedback -- I like your idea about checking for which shasum is installed, I did not realize that the intention was for this validation to be optional, so I will update the code so that it does not fail if the validation does not succeed.

Eventually, this PR could fix #1202 as well. I think we can drop usage of wget and use curl for all requests.

I can also update the code to use curl here instead, that should be a simple fix.

EDIT: I just spent some time on the two items above and I think I have a good idea of how to accomplish both of these. I'll have an updated PR soon.

[sundowndev]

@HudsonOnHere Thanks for following up!

On a second thought, let's perform the check on which program is available and then still exit with error when the verification fails. However, we can display a warning message if neither sha256sum or shasum is installed.

[richwrightnyc]

Sounds good to me -- I should have some updates in the next day or two.

[richwrightnyc]

@sundowndev I think this update should address all of our concerns. Sorry for the amount of changes introduced, but I thought it would be best to refactor the code so that we could handle everything better and make it more robust.

Here's what changed:

• Made checksum validation mandatory
• added an optional flag to skip checksum in case it's needed
• added a manual download mode as an option, or as a fallback in case the automatic check with uname fails for some reason.
• added a detailed help message with usage examples
• added checks for wget before downloading, if not installed use curl
• added checks for sha256sum before checksum validation, if not installedl use shasum

[sundowndev]

I think we're almost good.

Remaining changes:

• Fix the user input not working on manual mode
• Fix issues highlighted by shellcheck

[richwrightnyc]

Remaining changes:

• Fix the user input not working on manual mode

@sundowndev Please see my comment on our thread above, the solution is to fetch the script using a different command

bash <( curl -sSL https://raw.githubusercontent.com/sundowndev/phoneinfoga/78c4478f7b6988531e041e9196b0ca768cef975e/support/scripts/install ) -m

• Fix issues highlighted by shellcheck (see below)

These issues have been corrected

[richwrightnyc]

Left a comment about the list of supported OS

Sorry I must be missing it, I don't see anything

[sundowndev]

@HudsonOnHere Sorry it was a mistake on my end.