Skip to content
This repository has been archived by the owner on Jan 11, 2021. It is now read-only.

Migrate to stabilized x86/x86_64 SIMD #113

Closed
sunchao opened this issue May 7, 2018 · 1 comment
Closed

Migrate to stabilized x86/x86_64 SIMD #113

sunchao opened this issue May 7, 2018 · 1 comment
Assignees

Comments

@sunchao
Copy link
Owner

sunchao commented May 7, 2018

Currently the SIMD feature requires the x86intrin crate and a compile time flag RUSTFLAGS="-C target-feature=+sse4.2". Since x86/x86_64 SIMD is already stabilized, we should no longer need this crate dependency, and more importantly, enable feature check at run time via the command: is_x86_feature_detected.

@sunchao sunchao self-assigned this May 7, 2018
@sadikovi
Copy link
Collaborator

sadikovi commented May 9, 2018

That is great! I am curious if there is a nightly release with this PR already. Will update my Rust version!

sunchao added a commit that referenced this issue May 9, 2018
Currently the SIMD feature requires the x86intrin crate and a compile
time flag `RUSTFLAGS="-C target-feature=+sse4.2"`, which is not
convenient. This replaces the x86intrin dependency with recently
stablized SIMD features, and also replaces the `cfg(target_feature)`
flag with `is_x86_feature_detected`, which dynamically determines
whether SSE 4.2 is supported or not.

Fixes #113.
sunchao added a commit that referenced this issue May 10, 2018
Currently the SIMD feature requires the x86intrin crate and a compile
time flag `RUSTFLAGS="-C target-feature=+sse4.2"`, which is not
convenient. This replaces the x86intrin dependency with recently
stablized SIMD features, and also replaces the `cfg(target_feature)`
flag with `is_x86_feature_detected`, which dynamically determines
whether SSE 4.2 is supported or not.

Fixes #113.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants