Skip to content
This repository has been archived by the owner on Mar 31, 2021. It is now read-only.

feat(deps): upgrade Foundry and Circuit UI #22

Closed
wants to merge 5 commits into from

Conversation

felixjung
Copy link
Contributor

@felixjung felixjung commented Jul 31, 2020

Addresses TL-122.

This PR upgrades Foundry to version 3.0.0 and Circuit to version 2.0.0, addressing any breaking changes in those dependencies and links to documentation in the README.

Copy link
Member

@connor-baer connor-baer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these updates! 🙌

I was thinking of turning this project into a custom template for CRA. What do you think of that idea?

@connor-baer
Copy link
Member

Also, when you merge this, please mark it as a breaking change so that it's released as a new major version.

@felixjung
Copy link
Contributor Author

Template sounds cool. Didn't know they had that nowadays. Also just realized that the create-component script is not set up right. Will fix that.

@herberthenrique
Copy link
Contributor

What are we missing to merge this? 🤔
cc @felixjung

@felixjung
Copy link
Contributor Author

I need to fix the create-component script. Sorry. Will do so today.

@felixjung
Copy link
Contributor Author

felixjung commented Oct 30, 2020

This is turning out more difficult than I had hoped. We install create-react-app at latest. The new version uses React 17, which is not compatible with Emotion 10's jsx transform (emotion-js/emotion#1970). I tried an older version, but that also has React 17. Will need to investigate this further. We'd need to explicitly configure the non-automatic runtime for React. Haven't investigated how to do that, yet.

@connor-baer
Copy link
Member

connor-baer commented Nov 25, 2020

@felixjung Emotion 10 now supports the new jsx transforms (here are the docs). When you have time, would you mind taking another look at this, please? 🙏

@felixjung
Copy link
Contributor Author

Yes, will do. Already use them on my personal website. 🙃

@felixjung
Copy link
Contributor Author

Closing in favor of #26.

@felixjung felixjung closed this Nov 27, 2020
@felixjung felixjung deleted the chore/update-dependencies branch November 27, 2020 14:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants