Embedded translations (proof of concept) #2786
Draft
+932
−128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +18.4 kB (+2.86%) Total Size: 660 kB
ℹ️ View Unchanged
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2786 +/- ##
==========================================
+ Coverage 87.31% 87.33% +0.01%
==========================================
Files 216 217 +1
Lines 12671 12771 +100
Branches 1705 1725 +20
==========================================
+ Hits 11064 11153 +89
- Misses 1554 1565 +11
Partials 53 53
|
connor-baer
force-pushed
the
feature/i18n
branch
from
881e75f
to
bb67cec
Compare
sirineJ
reviewed
Nov 21, 2024
sirineJ
approved these changes
Nov 25, 2024
connor-baer
changed the title
connor-baer
force-pushed
the
feature/i18n
branch
from
9b6b3ef
to
6354e86
Compare
connor-baer
force-pushed
the
feature/i18n
branch
from
6354e86
to
b327347
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses DSYS-850.
Purpose
Historically, the design system has concerned itself with the layout and styling of content, not the content itself. Developers were expected to provide the content as props.
This makes sense for highly dynamic and contextual content such as headings, body copy, navigation links and so on. However, there are a handful of labels that don’t change regardless of the context, such as the close button label in a modal or the input labels in the date input.
Approach and changes
useI18nhook receives the component props and translations. If a custom translation isn't provided via the props, it returns default translations for the first supported locale, falling back toen-USif no supported locale was found.Definition of done