Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds BACS direct debit logo #2605

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

briannailiev
Copy link
Contributor

Addresses ECOM-3579

Purpose

We are offering a GB specific direct debit payment method.

Approach and changes

Added logo for the BACS payment method.

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2024 9:51am

Copy link

changeset-bot bot commented Jul 17, 2024

⚠️ No Changeset found

Latest commit: a89fc6e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.30%. Comparing base (0e76c53) to head (a89fc6e).
Report is 183 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2605   +/-   ##
=======================================
  Coverage   88.30%   88.30%           
=======================================
  Files         206      206           
  Lines       22813    22813           
  Branches     1527     1527           
=======================================
  Hits        20144    20144           
  Misses       2617     2617           
  Partials       52       52           

Copy link
Member

@connor-baer connor-baer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to find the icon in the Figma library. Please make sure the icon is added there first and review the icon contribution guidelines to ensure that the SVG meets all requirements.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SVG should not contain any class names and is missing a fill or stroke.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking into it, thanks for the comments!

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Add a comment explaining why the pull request is still relevant to prevent it from being closed.

@github-actions github-actions bot added stale and removed stale labels Sep 17, 2024
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Add a comment explaining why the pull request is still relevant to prevent it from being closed.

@github-actions github-actions bot added stale and removed stale labels Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants