Skip to content

Commit

Permalink
asddressed comments
Browse files Browse the repository at this point in the history
Signed-off-by: sumukhswamy <[email protected]>
  • Loading branch information
sumukhswamy committed Sep 4, 2024
1 parent e5e683c commit a021893
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion public/components/notebooks/components/main.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ export class Main extends React.Component<MainProps, MainState> {
console.error('Issue in fetching the notebooks', err.body.message);
});
} else {
// If `MDS` is not enabled, fetch from both endpoints and combine the data.
// If `MDS` is not enabled /savedNotebook/ API returns notebooks stored as saved objects, and the other one returns notebooks stored as observability objects.
return Promise.all([
this.props.http.get(`${NOTEBOOKS_API_PREFIX}/savedNotebook/`),
this.props.http.get(`${NOTEBOOKS_API_PREFIX}/`),
Expand Down
5 changes: 2 additions & 3 deletions public/components/notebooks/components/note_table.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import {
EuiSpacer,
EuiTableFieldDataColumnType,
EuiText,
EuiTitle
EuiTitle,
} from '@elastic/eui';
import truncate from 'lodash/truncate';
import moment from 'moment';
Expand All @@ -41,7 +41,7 @@ import {
} from '../../../../common/constants/notebooks';
import { UI_DATE_FORMAT } from '../../../../common/constants/shared';
import { setNavBreadCrumbs } from '../../../../common/utils/set_nav_bread_crumbs';
import { HeaderControlledComponentsWrapper } from '../../../../public/plugin_headerControl';
import { HeaderControlledComponentsWrapper } from '../../../../public/plugin_helpers/plugin_headerControl';
import { coreRefs } from '../../../framework/core_refs';
import {
DeleteNotebookModal,
Expand Down Expand Up @@ -186,7 +186,6 @@ export function NoteTable({
getSampleNotebooksModal(
closeModal,
async () => {
console.log(selectedDataSourceId, selectedDataSourceLabel);
closeModal();
await addSampleNotebooks(selectedDataSourceId, selectedDataSourceLabel);
},
Expand Down

0 comments on commit a021893

Please sign in to comment.