Skip to content

Commit

Permalink
added fixes for ui
Browse files Browse the repository at this point in the history
Signed-off-by: sumukhswamy <[email protected]>
  • Loading branch information
sumukhswamy committed Jul 23, 2024
1 parent 6df074b commit 94d1241
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ exports[`<Notebook /> spec Renders the visualization component 1`] = `
>
<button
class="euiButton euiButton--primary"
data-test-subj="migrate-notebook"
data-test-subj="upgrade-notebook"
type="button"
>
<span
Expand Down
14 changes: 7 additions & 7 deletions public/components/notebooks/components/notebook.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ import { DataSourceManagementPluginSetup } from '../../../../../../src/plugins/d
import { CREATE_NOTE_MESSAGE, NOTEBOOKS_API_PREFIX } from '../../../../common/constants/notebooks';
import { UI_DATE_FORMAT } from '../../../../common/constants/shared';
import { ParaType } from '../../../../common/types/notebooks';
import { setNavBreadCrumbs } from '../../../../common/utils/set_nav_bread_crumbs';
import PPLService from '../../../services/requests/ppl';
import { GenerateReportLoadingModal } from './helpers/custom_modals/reporting_loading_modal';
import { defaultParagraphParser } from './helpers/default_parser';
Expand All @@ -50,7 +51,6 @@ import {
generateInContextReport,
} from './helpers/reporting_context_menu_helper';
import { Paragraphs } from './paragraph_components/paragraphs';
import { setNavBreadCrumbs } from '../../../../common/utils/set_nav_bread_crumbs';
const panelStyles: CSS.Properties = {
float: 'left',
width: '100%',
Expand Down Expand Up @@ -339,7 +339,7 @@ export class Notebook extends Component<NotebookProps, NotebookState> {
this.setState({ isModalVisible: true });
};

showMigrateModal = () => {
showUpgradeModal = () => {
this.setState({
modalLayout: getCustomModal(
(newName: string) => {
Expand All @@ -353,10 +353,10 @@ export class Notebook extends Component<NotebookProps, NotebookState> {
},
() => this.setState({ isModalVisible: false }),
'Name',
'Migrate notebook',
'Upgrade notebook',
'Cancel',
'Migrate',
this.state.path + ' (migrated)',
'Upgrade',
this.state.path + ' (upgraded)',
CREATE_NOTE_MESSAGE
),
});
Expand Down Expand Up @@ -1091,8 +1091,8 @@ export class Notebook extends Component<NotebookProps, NotebookState> {
<>
<EuiFlexItem grow={false}>
<EuiButton
data-test-subj="migrate-notebook"
onClick={() => this.showMigrateModal()}
data-test-subj="upgrade-notebook"
onClick={() => this.showUpgradeModal()}
>
Upgrade Notebook
</EuiButton>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -565,7 +565,7 @@ export const Paragraphs = forwardRef((props: ParagraphProps, ref) => {
onSelectedDataSource={onSelectedDataSource}
disabled={false}
fullWidth={false}
removePrepend={true}
removePrepend={false}
defaultOption={
paradataSourceMDSId !== undefined && [
{ id: paradataSourceMDSId, label: dataSourceMDSLabel },
Expand Down

0 comments on commit 94d1241

Please sign in to comment.