addressed pr comments

Signed-off-by: sumukhswamy <[email protected]>
sumukhswamy · Jul 25, 2024 · 5549094 · 5549094
1 parent adc838c
commit 5549094
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/common/types/observability_saved_object_attributes.ts b/common/types/observability_saved_object_attributes.ts
@@ -9,7 +9,6 @@ import { SavedQuery, SavedVisualization } from './explorer';
 export const VISUALIZATION_SAVED_OBJECT = 'observability-visualization';
 export const SEARCH_SAVED_OBJECT = 'observability-search';
 export const NOTEBOOK_SAVED_OBJECT = 'observability-notebook';
-export const NOTEBOOK_SAVED_OBJECT_PATH = 'observability-notebooks';
 export const OBSERVABILTY_SAVED_OBJECTS = [
   VISUALIZATION_SAVED_OBJECT,
   SEARCH_SAVED_OBJECT,

diff --git a/server/saved_objects/observability_saved_object.ts b/server/saved_objects/observability_saved_object.ts
@@ -4,10 +4,9 @@
  */
 
 import { SavedObjectsType } from '../../../../src/core/server';
-import { observabilityLogsID } from '../../common/constants/shared';
+import { observabilityLogsID, observabilityNotebookID } from '../../common/constants/shared';
 import {
   NOTEBOOK_SAVED_OBJECT,
-  NOTEBOOK_SAVED_OBJECT_PATH,
   SEARCH_SAVED_OBJECT,
   VISUALIZATION_SAVED_OBJECT,
 } from '../../common/types/observability_saved_object_attributes';
@@ -94,7 +93,7 @@ export const notebookSavedObject: SavedObjectsType = {
       return obj.attributes.title;
     },
     getInAppUrl(obj) {
-      const editUrl = `/app/${NOTEBOOK_SAVED_OBJECT_PATH}#/${obj.id}?view=view_both`;
+      const editUrl = `/app/${observabilityNotebookID}#/${obj.id}?view=view_both`;
       return {
         path: editUrl,
         uiCapabilitiesPath: 'observability.show',