Make has_many relationships return an empty collection when no parent #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x-yuri
force-pushed
the
relationships-nested-under
branch
from
dd0afcd
to
7bda03b
Compare
|
Hey @x-yuri Sorry for the late late reply, |
bobbrodie
approved these changes
May 27, 2024
I haven't used this project since that time, and I don't even remember what exactly this PR changes. So unfortunately no :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #366.
It supposedly needs
ruby >= 2.3.0. It probably affects other types of relationships. Some tests regarding nesting becomes not needed. Should I proceed in this direction, or double back and just make it work for (not deeply) nested collections, and not introduceHash#dig?