Bug updating the resource after a save #176
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the attribute to update is a hash and it is nill, then the wrong
attributes are being updated.
I found this bug while I was updating the assignee in an issue without
assignee. In that case, with this code:
issue.save!('fields' => { 'assignee' => user.attrs }) if issue.assignee.nil?
in this case, all the attributes of the user are being set to the issue,
for instance the issue.id becomes user.id, etc ...
This patch solves the issue and pases all the tests.
|
@AgarFu Could you add a test so we can merge it? |
|
@AgarFu Hey, I merge develop and solve the conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the attribute to update is a hash and it is nill, then the wrong
attributes are being updated.
I found this bug while I was updating the assignee in an issue without
assignee. In that case, with this code:
issue.save!('fields' => { 'assignee' => user.attrs }) if issue.assignee.nil?
All the attributes of the user are being set to the issue,
for instance the issue.id becomes user.id, etc ...
This patch solves the issue and pases all the tests.