PR for issue #42 [completed, awaiting review] #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DQ4443
commented
Jun 18, 2024
DQ4443
commented
- added config variable to config.py to change outline thickness globally
- updated corresponding draw.foo functions to use new global variable
- update README file and added optional "Configuration" section directing users to config file
- fixed minor formatting issues in README file
Added config variable in config.py and updated draw.foo functions to use the new config variable. feat: add description for configs to README file feat: fix minor formatting issues in README
|
@DQ4443 is attempting to deploy a commit to the Suman Kunwar's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sumn2u
requested changes
Jun 18, 2024
| ```python | ||
| # config.py | ||
| MASK_BACKGROUND_COLOR = (0, 0, 0) # Black background for masks | ||
| OUTLINE_THICKNESS = 5 # Thicker outlines (5 pixels) |
There was a problem hiding this comment.
Would be nice to create an object and assign values as per UI tools value. This will give us more flexibility, granularity and will be in sync.
OUTLINE_THICKNESS_CONFIG = {
"POLYGON": 2,
"CIRCLE": 2,
"BOUNDING_BOX": 2
}
| @@ -295,7 +295,7 @@ def download_image_with_annotations(): | |||
| points = region['points'] | |||
| scaled_points = [(x * width, y * height) for x, y in points] | |||
There was a problem hiding this comment.
If we define the OUTLINE_THICKNESS_CONFIG object mentioned above , think we can access it like this.
from config import OUTLINE_THICKNESS_CONFIG
....
# Load the outline thickness configuration
app.config.from_mapping(OUTLINE_THICKNESS_CONFIG)
OUTLINE_THICKNESS_CONFIG['LINE']
There was a problem hiding this comment.
I see. I'll make this change
Added links next to relevant headings that leads to the corresponding page in the documentation
This reverts commit f4c4334.
Updated OUTLINE_THICKNESS_CONFIG variable to be a struct to allow for higher granularity customization
|
Fixes #42 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.