-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor datepicker to move calendar out #27
Draft
MrWook
wants to merge
7
commits into
master
Choose a base branch
from
feat/append-to-body
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4993c40
refactor(calendar): move calendar in own component
MrWook 51b9790
feat(calendar): add props to add calendar to body
MrWook 651bd2c
chore(popup): set fixed position for relativ position
MrWook 847ddb1
chore(project): small fine tuning
MrWook 139b71a
feat(position): make fixedPosition workable again
MrWook 9dfa77b
fix(position): resolve position on right sided inputs
MrWook ea9bc22
docs(project): adjust docs for fixedPosition prop
MrWook File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,3 +38,7 @@ | |
.error { | ||
color: red; | ||
} | ||
|
||
.overflow-scroll { | ||
overflow:scroll | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,10 @@ | |
<h1>Datepicker Examples</h1> | ||
<div class="example"> | ||
<h3>Default datepicker...</h3> | ||
<Datepicker placeholder="Select Date" /> | ||
<Datepicker | ||
placeholder="Select Date" | ||
:append-to-body="true" | ||
/> | ||
<code> | ||
<datepicker placeholder="Select Date"></datepicker> | ||
</code> | ||
|
@@ -37,6 +40,7 @@ | |
<Datepicker | ||
v-model="vModelExample" | ||
placeholder="Select Date" | ||
:append-to-body="true" | ||
/> | ||
<code> | ||
<datepicker placeholder="Select Date" v-model="vmodelexample"></datepicker> | ||
|
@@ -45,6 +49,18 @@ | |
<p>{{ vModelExample }}</p> | ||
</div> | ||
|
||
<div class="example overflow-scroll"> | ||
<h3>Append datepicker to body</h3> | ||
<Datepicker | ||
:append-to-body="true" | ||
/> | ||
<h3>Don't append datepicker to body</h3> | ||
<Datepicker /> | ||
<code> | ||
<datepicker :append-to-body="true"></datepicker> | ||
</code> | ||
</div> | ||
|
||
<div class="example"> | ||
<h3>Format datepicker</h3> | ||
<Datepicker :format="format" /> | ||
|
@@ -294,6 +310,29 @@ | |
:initialView="'year'"></datepicker> | ||
</code> | ||
</div> | ||
|
||
<div class="example"> | ||
<h3>Fixed positions</h3> | ||
<Datepicker | ||
:fixed-position="fixedPosition" | ||
:append-to-body="true" | ||
/> | ||
<code> | ||
<datepicker :fixed-position="fixedPosition"></datepicker> | ||
</code> | ||
<div class="settings"> | ||
<h5>Settings</h5> | ||
<select v-model="fixedPosition"> | ||
<option | ||
v-for="(position) in fixedPositions" | ||
:key="position" | ||
:value="position" | ||
> | ||
{{ position }} | ||
</option> | ||
</select> | ||
</div> | ||
</div> | ||
</div> | ||
</template> | ||
|
||
|
@@ -369,6 +408,15 @@ export default { | |
vModelExample: null, | ||
languages: lang, | ||
language: 'en', | ||
fixedPositions: [ | ||
'bottom', | ||
'bottom-left', | ||
'bottom-right', | ||
'top', | ||
'top-left', | ||
'top-right', | ||
], | ||
fixedPosition: 'bottom', | ||
} | ||
}, | ||
computed: { | ||
|
@@ -499,4 +547,7 @@ h5 { | |
font-size: 80%; | ||
display: block; | ||
} | ||
.overflow-scroll { | ||
overflow:scroll | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Formatting: |
||
} | ||
</style> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting:
overflow: scroll;