Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup e2e testing with BDD, Cypress & Cucumber #126

Merged
merged 6 commits into from
Aug 18, 2021

Conversation

mst101
Copy link
Contributor

@mst101 mst101 commented Aug 10, 2021

A continuation of #91 (which I deleted by accident!).

N.B. Until Cypress supports native events, I've commented out a number of tests which involve pressing the space bar or enter keys on a button as Cypress currently treats these exactly the same way as if you had clicked on the button. i.e. the following three lines are equivalent:

cy.get('.my-button').type('{enter}')
cy.get('.my-button').type(' ')
cy.get('.my-button').click()

@MrWook MrWook added the enhancement New feature or request label Aug 10, 2021
@MrWook
Copy link
Collaborator

MrWook commented Aug 10, 2021

Is this done? It's a lot of stuff :D

@mst101
Copy link
Contributor Author

mst101 commented Aug 10, 2021

Yes, it's done. Nothing new here really, other than commenting out the above-mentioned tests...

I've just merged in the previous PR.

N.B. It seems one of the relocated tests from the test(unit): Relocate typeable tests commit was mistakenly dropped in the last PR, so it's been added again in this one.

@MrWook
Copy link
Collaborator

MrWook commented Aug 16, 2021

He @mst101 i just wanted to merge this but before that i wanted to try it out.
Unfortunately every e2e test failed on my machine :(
I think there error lies in the data-test-${testSelector}. If i'm correct cypress best practice is to add a data-test attribute to the html if you want to select it and the data-test-${testSelector} is the selector for this attribute but there is no such attribute on any of the html element. Maybe they got lost somewhere?

@mst101
Copy link
Contributor Author

mst101 commented Aug 18, 2021

Yes, that's right. They will all fail as the implementation that satisfies these tests is all within the Keyboard Navigation PR (#81).

Sorry if that wasn't clear... Perhaps I should have combined the two PRs?

@MrWook MrWook merged commit e15b48d into sumcumo:master Aug 18, 2021
@mst101
Copy link
Contributor Author

mst101 commented Aug 18, 2021

@MrWook - thanks. I'm just about to merge your updated master branch into my keyboard navigation branch. Then you'll be able to check that out...

@mst101 mst101 deleted the test/e2e branch April 27, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants