Fix admin build with webpack 4 #6934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
added
the
Bug
| @@ -10,7 +10,7 @@ export default class HtmlFieldTransformer implements FieldTransformer { | |||
| return null; | |||
| } | |||
|
|
|||
| const sanitizedHtml = sanitizeHtml(value, { | |||
| const sanitizedHtml = sanitizeHtml(value.toString(), { | |||
There was a problem hiding this comment.
The new release also changed the behaviour for numbers and we need todo a toString() here now: apostrophecms/sanitize-html#593
Prokyonn
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Fix admin build with webpack 4. Also the HtmlFieldTransformer is required to work like before.
Why?
Currently the admin build is failing, because of sanitze-html 2.8 version which also changed behaviour for numbers which need to be adjusted:
Update other related issues: