add last login refresh request event listener #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
feature/last-login-refresh
branch
from
e5d881d to
1f6870d
Compare
alexander-schranz
force-pushed
the
feature/last-login-refresh
branch
from
1f6870d to
2a4bb8a
Compare
wachterjohannes
requested changes
Mar 13, 2017
| @@ -79,6 +83,12 @@ public function getConfigTreeBuilder() | |||
|
|
|||
| $rootNode | |||
| ->children() | |||
| ->arrayNode(self::LAST_LOGIN) | |||
There was a problem hiding this comment.
i would use canBeEnabled and set a default value to refresh_interval
EventListener/LastLoginListener.php
Outdated
| use Symfony\Component\HttpKernel\Event\FilterControllerEvent; | ||
| use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface; | ||
|
|
||
| class LastLoginListener |
EventListener/LastLoginListener.php
Outdated
| * | ||
| * @param FilterControllerEvent $event | ||
| */ | ||
| public function onCoreController(FilterControllerEvent $event) |
There was a problem hiding this comment.
why not on kernel.terminate?
There was a problem hiding this comment.
@wachterjohannes if I remember it correctly we did that if a query based on active users dont return 0 users when 1 user is online and the last login will be refreshed.
EventListener/LastLoginListener.php
Outdated
| */ | ||
| public function isActiveNow(BaseUser $user) | ||
| { | ||
| $delay = new \DateTime($this->interval . ' minutes ago'); |
There was a problem hiding this comment.
could you configure this string? 10 minutes or 10 seconds you could then configure it more accuate for your application. 10 minutes seems a good default - but some faster applications maybe want to configure that in seconds or in hours for very slow apps.
There was a problem hiding this comment.
@wachterjohannes only want an integer value in the configuration but can set it to seconds so it like the cacheLifetime. ok?
UPGRADE.md
Outdated
| ### Parameter `sulu_community.config` was removed | ||
|
|
||
| The whole config as parameter is not longer available the webspaces config | ||
| you can get over the `sulu_community.webspaces` parameter. |
There was a problem hiding this comment.
calling it sulu_community.webspace_config maybe?
There was a problem hiding this comment.
@wachterjohannes it is not a single webspace it contains all webspaces
There was a problem hiding this comment.
sulu_community.webspaces_config?
|
@wachterjohannes ready |
wachterjohannes
approved these changes
Mar 13, 2017
|
@alexander-schranz will wait for tests and then merging it. |
Merged
alexander-schranz
pushed a commit
to alexander-schranz/SuluCommunityBundle
that referenced
this pull request
Dec 4, 2017
* Fixed dynamic list factory with hidden fields
alexander-schranz
added a commit
to alexander-schranz/SuluCommunityBundle
that referenced
this pull request
Dec 4, 2017
# Changelog - FEATURE sulu#59 Added correct composer dependencies - FEATURE sulu#57 Added basic theme for dynamic forms - FEATURE sulu#56 Added daterange to csv export overlay for sulu 1.5 - BUGFIX sulu#55 Fixed dynamic list factory with hidden fields - BUGFIX sulu#54 Fixed date type default value - ENHANCEMENT sulu#52 Update sulu from `alexander-schranz/sulu-form-bundle` from commit `c110e72e44a58a0f53428c153e405124695506f6` - BUGFIX sulu#52 Fixed form preview request analyzer - BUGFIX sulu#52 Fixed second date field type - BUGFIX sulu#52 Fixed missing translation and documentation - ENHANCEMENT sulu#52 Added missing documentation - BUGFIX sulu#52 Fixed success email not sent to email in data json - BUGFIX sulu#52 Fixed missing uniqueness in form fields table - BUGFIX sulu#52 Fixed permission denied on fields action - FEATURE sulu#52 Added toggler to set email as replyTo - BUGFIX sulu#52 Fixed exception controller redirect - BUGFIX sulu#52 Fixed form select by using native select - FEATURE sulu#52 Added media collection strategy tree - FEATURE sulu#52 Added support to add dynamic list to article bundle - BUGFIX sulu#52 Fixed csv export for bool values - ENHANCEMENT sulu#52 Fixed sort on dynamic list and removed search - FEATURE sulu#52 Added dynamic form list and export - FEATURE sulu#20 Added additional receivers for sending notification as CC or BCC - ENHANCEMENT sulu#23 Fixed composer json links and description - BUGFIX sulu#16 Fixed setting of entity value in dynamic which represents an array - ENHANCEMENT sulu#13 Added dynamic type pool service for enabling custom form field types - ENHANCEMENT sulu#10 Update sulu from `alexander-schranz/sulu-form-bundle` from commit `c16a04b15fe320c039064de05ddaef9d087dbc6f` - BUGFIX sulu#10 Fixed permission problem on false locale - BUGFIX sulu#10 Fixed limitation of content type select - FEATURE sulu#10 Added options for attachment validation - BUGFIX sulu#10 Fixed multiple choices to text type columns - BUGFIX sulu#10 Fixed naming of mailchimp parameters - FEATURE sulu#3 Added short title to fields - FEATURE sulu#2 Changed title field for labels to texteditor - ENHANCEMENT #- Updated namespaces and rename table names - ENHANCEMENT #- Forked from `alexander-schranz/sulu-form-bundle` from commit `36a7cd11562ed0c9f64752b37707cc2771e0baca`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Add posibility to refresh last login every 10 minutes.