Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the "Sign in" link in the site brandbar #1372

Closed
ggeisler opened this issue Dec 16, 2021 · 2 comments · Fixed by #1674
Closed

Hide the "Sign in" link in the site brandbar #1372

ggeisler opened this issue Dec 16, 2021 · 2 comments · Fixed by #1674
Assignees
Labels

Comments

@ggeisler
Copy link
Contributor

This could be low priority but it also might be relatively easy and would improve the user experience on the (admittedly rare) occasions when a user selects the "Sign in" link the top-right of the site brandbar.

There are several improvements that could be made when selecting the "Sign in" link:

  • User accounts are not applicable to regular DLME users, but we don't make that clear
  • We don't display the site masthead on the Sign in / Sign up pages so those pages look sort of broken
  • We use inconsistent terminology on these pages ("Sign in" and "Log in")

Current "sign in" page ("sign up" is basically the same)

Screen Shot 2021-12-15 at 5 03 34 PM


Suggested updates

  • A: Add the DLME masthead to the page
  • B: Add a <div class="alert alert-warning" role="alert"> box so the user understands this isn't something they should waste time trying. Suggested text is The Digital Library of the Middle East website does not currently offer user accounts. This page is for website staff only.
  • C: Change the "Log in" heading to "Sign in" so it matches the link label

Screen Shot 2021-12-15 at 5 28 18 PM


If we do the above, we should also update the "Sign up" page, since the changes could be pretty much identical (add masthead, add alert box with the same text):

Screen Shot 2021-12-15 at 5 33 08 PM

@mwerla
Copy link

mwerla commented Jan 6, 2022

@ggeisler I think that if the login/sign up option is not applicable to end users, we should remove that from the public UI. Those few who use that function can simply bookmark the link.

@ggeisler
Copy link
Contributor Author

ggeisler commented Jan 6, 2022

@mwerla Sure, hiding the Sign in link would be even better. I was concerned that the team would not like the idea of having to bookmark/keep track of the Sign in URL, but if we're okay with that, just hiding the link would be simpler than updating the sign in and sign up pages.

If we go this route, we should make sure to use a technique that hides the Sign link both visually and from screen readers, such as adding a hidden attribute to the Sign in element (or I think styling it with display: none would be functionally equivalent).

Also, if we go this route, I would still love to see the step of "Add the DLME masthead to the page" for the sign in/sign up pages, because those pages feel clunky to me without the masthead and the availability of the accompanying main menu items. But since only DLME team members would ever see those pages, I recognize this is likely a very low priority.

@ggeisler ggeisler changed the title Clarify and tidy up login/sign up pages Hide the "Sign in" link in the site brandbar Jan 13, 2022
@jacobthill jacobthill moved this to Todo in DLME Access 2022 Sep 28, 2022
@thatbudakguy thatbudakguy self-assigned this Feb 15, 2023
thatbudakguy added a commit that referenced this issue Feb 17, 2023
This ensures that the header and navbar are still displayed on
pages where the masthead is not (like auth flow pages), and
removes some places where we overrode Spotlight.

See #1372
thatbudakguy added a commit that referenced this issue Feb 17, 2023
thatbudakguy added a commit that referenced this issue Feb 17, 2023
This ensures that the header and navbar are still displayed on
pages where the masthead is not (like auth flow pages), and
removes some places where we overrode Spotlight.

See #1372
thatbudakguy added a commit that referenced this issue Feb 17, 2023
@thatbudakguy thatbudakguy linked a pull request Feb 17, 2023 that will close this issue
thatbudakguy added a commit that referenced this issue Feb 21, 2023
thatbudakguy added a commit that referenced this issue Feb 21, 2023
thatbudakguy added a commit that referenced this issue Feb 23, 2023
This ensures that the header and navbar are still displayed on
pages where the masthead is not (like auth flow pages), and
removes some places where we overrode Spotlight.

See #1372
thatbudakguy added a commit that referenced this issue Feb 23, 2023
thatbudakguy added a commit that referenced this issue Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

3 participants