-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide the "Sign in" link in the site brandbar #1372
Comments
@ggeisler I think that if the login/sign up option is not applicable to end users, we should remove that from the public UI. Those few who use that function can simply bookmark the link. |
@mwerla Sure, hiding the Sign in link would be even better. I was concerned that the team would not like the idea of having to bookmark/keep track of the Sign in URL, but if we're okay with that, just hiding the link would be simpler than updating the sign in and sign up pages. If we go this route, we should make sure to use a technique that hides the Sign link both visually and from screen readers, such as adding a Also, if we go this route, I would still love to see the step of "Add the DLME masthead to the page" for the sign in/sign up pages, because those pages feel clunky to me without the masthead and the availability of the accompanying main menu items. But since only DLME team members would ever see those pages, I recognize this is likely a very low priority. |
This ensures that the header and navbar are still displayed on pages where the masthead is not (like auth flow pages), and removes some places where we overrode Spotlight. See #1372
This ensures that the header and navbar are still displayed on pages where the masthead is not (like auth flow pages), and removes some places where we overrode Spotlight. See #1372
This ensures that the header and navbar are still displayed on pages where the masthead is not (like auth flow pages), and removes some places where we overrode Spotlight. See #1372
This could be low priority but it also might be relatively easy and would improve the user experience on the (admittedly rare) occasions when a user selects the "Sign in" link the top-right of the site brandbar.
There are several improvements that could be made when selecting the "Sign in" link:
Current "sign in" page ("sign up" is basically the same)
Suggested updates
<div class="alert alert-warning" role="alert">
box so the user understands this isn't something they should waste time trying. Suggested text isThe Digital Library of the Middle East website does not currently offer user accounts. This page is for website staff only.
If we do the above, we should also update the "Sign up" page, since the changes could be pretty much identical (add masthead, add alert box with the same text):
The text was updated successfully, but these errors were encountered: