Remove abstract mapping tests not needed in Cocina>MODS direction #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcadiafalcone
commented
May 2, 2022
| end | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
Normalization not needed in Cocina>MODS direction.
arcadiafalcone
commented
May 2, 2022
| end | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
Specific type value does not matter, so this test is duplicative of the one at line 80.
arcadiafalcone
commented
May 2, 2022
| end | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
These tests all effectively duplicate the test at line 171.
arcadiafalcone
commented
May 2, 2022
| end | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
Normalization not needed in Cocina>MODS direction.
arcadiafalcone
commented
May 2, 2022
| end | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
Duplicative of test at line 171.
arcadiafalcone
commented
May 2, 2022
| end | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
Normalization not needed in Cocina>MODS direction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Changes to openapi.yml require updating openapi.yml for sdr-api and dor-services-app and generating models - see README.
Why was this change made? 🤔
Remove mapping tests not needed in Cocina>MODS direction for abstract.
How was this change tested? 🤨
⚡ ⚠ If this change has cross service impact, run integration tests and/or test in [stage|qa] environment, in addition to specs. ⚡