adds print stylesheets #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When printing gallery view page, view URLs CSS selector/class to hide in print stylesheet -
|
|
@jchristo4 Per @jvine in the ticket "Suppress the exposed URLs: EXCEPT for h3 titles in results (which show as /view/12345)" |
|
Yup. |
|
@mejackreed Looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #651
So one thing about this is, we are essentially loading the styles twice. I haven't been able to figure out a better way to do this. I think this should be fine when minified and concat'd in prod.
Record page - 493515
Results page - ?utf8=✓&search_field=search&q=cats
Gallery results - ?utf8=✓&search_field=search&q=cats&view=gallery
Brief results - ?utf8=✓&search_field=search&q=cats&view=brief