Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds course reserves to home page with new access points images #728

Merged
merged 1 commit into from
Aug 14, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added app/assets/images/course-reserves.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added app/assets/images/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified app/assets/images/dissertations-theses.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified app/assets/images/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified app/assets/images/selected-databases.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified app/assets/images/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 8 additions & 2 deletions app/views/catalog/_home_page.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,20 @@
<p>Dissertations and theses in Stanford's collections.</p>
</div>
</li>

<li class="media">
<%= image_tag('selected-databases.png', class: 'media-object pull-left', alt: "", title: '', data: { "no-link-href" => selected_databases_path }) %>
<div class="media-body">
<%= link_to "Selected databases", selected_databases_path, class: 'media-heading' %>
<%= link_to "Selected databases", selected_databases_path, class: 'media-heading' %>
<p>Not sure where to start? Find articles and reference information by discipline.</p>
</div>
</li>
<li class="media">
<%= image_tag('course-reserves.png', class: 'media-object pull-left', alt: "", title: '', data: { "no-link-href" => course_reserves_path }) %>
<div class="media-body">
<%= link_to "Course reserves", course_reserves_path, class: 'media-heading' %>
<p>Find print, media, and e-resources set aside for classes.</p>
</div>
</li>
</ul>
</div>
<div class="articles-help col-md-3 col-sm-6 home-page-column">
Expand Down
6 changes: 6 additions & 0 deletions spec/features/course_reserves_browse_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,10 @@

expect(page).to have_css('h1', text: 'Browse course reserves')
end
scenario "should be accessible from the home page" do
visit root_path
click_link "Course reserves"
expect(page).to have_css("h1", text: "Browse course reserves")
end

end
3 changes: 2 additions & 1 deletion spec/features/home_page_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,12 @@
expect(page).to have_css(".media a", text: "Digital collections")
expect(page).to have_css(".media a", text: "Dissertations & theses")
expect(page).to have_css(".media a", text: "Selected databases")
expect(page).to have_css(".media a", text: "Course reserves")
end
scenario "'Featured sets' images should be clickable", js: true do
within('.features') do
all('[data-no-link-href]').last.click
expect(current_url).to match /#{selected_databases_path}$/
expect(current_url).to match /#{course_reserves_path}$/
end
end
scenario "'Articles' section should display" do
Expand Down