This repository has been archived by the owner on Sep 9, 2022. It is now read-only.
Merge with ember-class-based-modifier #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a result of squashing everything after the v0.5.0 tag up to and including the v0.9.0 tag, rebased on top of the current master, which is the v0.5.2 tag. The original commits are at the [archive/ember-class-based-modifier-fork branch](https://github.com/sukima/ember-oo-modifiers/tree/archive/ember-class-based-modifier-fork) as a permanent archive, but the commits themselves are not very interesting. It's mainly there so that the `v0.8.0` and `v0.9.0` tags have something to point to.
chancancode
force-pushed
the
ember-class-based-modifier-squashed
branch
from
c879db5 to
6351de1
Compare
sukima
reviewed
Sep 19, 2019
chancancode
force-pushed
the
ember-class-based-modifier-squashed
branch
from
6351de1 to
46d8592
Compare
sukima
approved these changes
Sep 19, 2019
|
@chancancode Done, Should be ready to merge. I think you have access to all that |
|
@sukima looks good to me! CI is green to so I think we can merge this any time! I don't have access to ember-oo-modifiers yet, but I think this takes a long time to propagate on NPM, and it's not urgent anyway. I assume you may also have the opposite issue? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a result of squashing everything after the v0.5.0 tag up to and including the v0.9.0 tag, rebased on top of the current master, which is the v0.5.2 tag.
The original commits are at the archive/ember-class-based-modifier-fork branch as a permanent archive, but the commits themselves are not very interesting. It's mainly there so that the v0.8.0 and v0.9.0 tags have something to point to.
ember-class-based-modifierember-oo-modifiers, just in case we need to cut more maintenance releases?ember-class-based-modifierin the repo Settings? I believe it could be done either before or after the merge.Thank you very much for the fast turnaround!!
Closes #9 and #14!