Suisin/upm1058/api integration and flows #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ub.com:suisin-deriv/deriv-app into suisin/UPM1058/api_integration_and_flows
…ub.com:suisin-deriv/deriv-app into suisin/UPM1058/api_integration_and_flows
amina-deriv
reviewed
Jul 2, 2024
| @@ -16,7 +16,10 @@ const Routes = observer(() => { | |||
|
|
|||
| return ( | |||
| <ThemeProvider theme={is_dark_mode_on ? 'dark' : 'light'}> | |||
| <BinaryRoutes is_logged_in={is_logged_in} is_logging_in={is_logging_in} /> | |||
| <SnackbarProvider> | |||
There was a problem hiding this comment.
why not we use standalone snackbar comonent?
https://quill-ui.pages.dev/?path=/docs/components-snackbar-standalone--documentation
There was a problem hiding this comment.
I tried to use standalone snackbar component but the design is not as expected that's why i added the SnackbarProvider here
suisin-deriv
merged commit c394c33
into
suisin/utkarsha/UPM819/phone_verification_flow
1 check failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Update FE code after BE Integration.
Screenshots:
Please provide some screenshots of the change.