Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove clear confirmation on loading new project #4172

Merged
merged 5 commits into from
Dec 25, 2024

Conversation

subhas-pramanik-09
Copy link
Contributor

Resolve #4170

Removed unnecessary clear confirmation after loading of new project

Screen.Recording.2024-12-23.012024.mp4

@subhas-pramanik-09
Copy link
Contributor Author

@walterbender Sir please review it

@walterbender
Copy link
Member

I guess I was not clear about clear. I don't think we want to clear at all when loading a new project. @pikurasa what do you think?

@subhas-pramanik-09
Copy link
Contributor Author

I guess I was not clear about clear. I don't think we want to clear at all when loading a new project. @pikurasa what do you think?

Sir, That's means the desired behavior is not clear after loading project

@subhas-pramanik-09
Copy link
Contributor Author

Sir I removed the clear after loading of new Project because we don't need of this

@haroon10725
Copy link
Contributor

#4153
It has been fixed here.

@subhas-pramanik-09
Copy link
Contributor Author

#4153 It has been fixed here.

It was during loading but this PR fixes the issue with after loading of the new project

@subhas-pramanik-09
Copy link
Contributor Author

@walterbender Sir, is this okay or something needs to be changed ?

@walterbender
Copy link
Member

I am waiting for Devin to comment on whether or not we want to clear on load. IMHO, we do not.

@pikurasa
Copy link
Collaborator

pikurasa commented Dec 24, 2024

I am waiting for Devin to comment on whether or not we want to clear on load. IMHO, we do not.

Clear to what extent?

We should probably always clear box and heap upon loading a new project, even if the image remains. Otherwise, what is stored in box and heap may interfere with running the new project.

@subhas-pramanik-09
Copy link
Contributor Author

I am waiting for Devin to comment on whether or not we want to clear on load. IMHO, we do not.

Clear to what extent?

We should probably always clear box and heap upon loading a new project, even if the image remains. Otherwise, what is stored in box and heap may interfere with running the new project.

So that's mean we have to clear the canvas while loading of new project from file

@subhas-pramanik-09
Copy link
Contributor Author

subhas-pramanik-09 commented Dec 24, 2024

@walterbender Sir I have updated it. Clean the canvas during loading of project but without confirmation.

js/activity.js Outdated Show resolved Hide resolved
@subhas-pramanik-09
Copy link
Contributor Author

@walterbender Sir I changed it

@walterbender walterbender merged commit a99c894 into sugarlabs:master Dec 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove clear from load new project
4 participants