Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3 built in types and directives #4

Merged
merged 2 commits into from
Oct 27, 2021

Conversation

AlwxSin
Copy link
Contributor

@AlwxSin AlwxSin commented Oct 25, 2021

There are https://github.com/vektah/gqlparser/blob/master/validator/prelude.go and prelude.graphql. But gqlfetch doesn't use gqlparser, so I can't use it either.
Just ignore built in completely.

closes #3

@suessflorian
Copy link
Owner

suessflorian commented Oct 25, 2021

Hey @AlwxSin, so I ran into this as well and decided to push that responsibility to genqlient - Khan/genqlient#145. It will be cleaner to not have to manage what an explicit and implicit schema definition is here in this tool.

@suessflorian
Copy link
Owner

I still feel there is value in this, but perhaps we can have a flag like --implicit that continues to strip (rather than baking it in as a default).

What are your thoughts @AlwxSin?

@AlwxSin
Copy link
Contributor Author

AlwxSin commented Oct 25, 2021

@suessflorian adding --implicit flag pretty easy in a straight way, we can pass this flag to all print functions.

But I think it's not clear enough. Maybe we can call it --without-builtins or even --without-builtins-types?

@suessflorian
Copy link
Owner

@AlwxSin, yeah I like --without-builtins, are you okay to continue on this here? Or did you want me to take care of this?

@AlwxSin
Copy link
Contributor Author

AlwxSin commented Oct 26, 2021

@suessflorian yeah, I'll continue here, thanks

@suessflorian
Copy link
Owner

Looks cool, thanks for the hand @AlwxSin 👍

@suessflorian suessflorian merged commit 94019f8 into suessflorian:main Oct 27, 2021
@AlwxSin AlwxSin deleted the fix/build-in-types-directives branch October 27, 2021 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Built in types and directives
2 participants