Merge "compute: Allow snapshots to be created from PAUSED volume back…

…ed instances" into stable/stein
sue-fly · Jul 24, 2020 · e91540f · e91540f
2 parents 5482dde + 04a8399
commit e91540f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/nova/compute/api.py b/nova/compute/api.py
@@ -3152,7 +3152,7 @@ def snapshot(self, context, instance, name, extra_properties=None):
     # NOTE(melwitt): We don't check instance lock for snapshot because lock is
     #                intended to prevent accidental change/delete of instances
     @check_instance_state(vm_state=[vm_states.ACTIVE, vm_states.STOPPED,
-                                    vm_states.SUSPENDED])
+                                    vm_states.PAUSED, vm_states.SUSPENDED])
     def snapshot_volume_backed(self, context, instance, name,
                                extra_properties=None):
         """Snapshot the given volume-backed instance.

diff --git a/nova/tests/unit/compute/test_compute_api.py b/nova/tests/unit/compute/test_compute_api.py
@@ -3450,6 +3450,11 @@ def test_snapshot_volume_backed_with_suspended(self):
                                           quiesce_unsupported=True,
                                           vm_state=vm_states.SUSPENDED)
 
+    def test_snapshot_volume_backed_with_pause(self):
+        self._test_snapshot_volume_backed(quiesce_required=False,
+                                          quiesce_unsupported=True,
+                                          vm_state=vm_states.PAUSED)
+
     @mock.patch.object(context, 'set_target_cell')
     @mock.patch.object(objects.BlockDeviceMapping, 'get_by_volume')
     def test_get_bdm_by_volume_id(self, mock_get_by_volume,