Allow use of empty string as a value for a Attribute #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, please add a test that covers this behavior.
…On Thu, Sep 12, 2024 at 2:01 AM Martin Pilros ***@***.***> wrote:
As talked about in #107
<#107>
No tests are affected by this change, all tests ran fine locally.
------------------------------
You can view, comment on, or merge this pull request online at:
#108
Commit Summary
- 2975319
<2975319>
Allow use of empty string as a value for a Attribute
File Changes
(1 file <https://github.com/suds-community/suds/pull/108/files>)
- *M* suds/mx/appender.py
<https://github.com/suds-community/suds/pull/108/files#diff-369ac5db3035c5f356609da230d9b8cac2acc921bbea752a19e2fbdb76bbbece>
(4)
Patch Links:
- https://github.com/suds-community/suds/pull/108.patch
- https://github.com/suds-community/suds/pull/108.diff
—
Reply to this email directly, view it on GitHub
<#108>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAXCKNTJQHGLJLIDYOOLOTZWEU5NAVCNFSM6AAAAABOCM3OMCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGUZDCNBSGY4DCNA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
After looking into "tostr" simplified the code a bit, but I would say that the check must have been used to block empty strings as tostr will always return a string. Hope that this is still something that can be added to suds. |
phillbaker
reviewed
Sep 17, 2024
tostr will always return a string regardless of input, no check on value is needed as empty string is allowed. Change-Id: I9204f196ad5b6df33451e012d764a32922b577c3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As talked about in #107
No tests are affected by this change, all tests ran fine locally.