Web/fix intial render #1120
Merged
Web/fix intial render #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor to use useRouteLoaderData for more accurate data scoping. Ensures data retrieval is tied specifically to the 'root' route, improving clarity and code reliability.
Replaced memoized Header component with a standard function for clarity and maintainability. Removed unnecessary useCallback and useMemo hooks, simplifying the component logic. This change improves code readability without impacting functionality.
Refactor `ModeToggle` component to improve readability and performance. Replaced `useMemo` usage with direct comparison logic for theme detection. Introduced a reusable `makeToggleHandler` function for cleaner event handling.
|
suddenlyGiovanni
temporarily deployed
to
review
GitHub Actions
Inactive
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Provide clear instructions for scroll management and script tags, including nonce requirements for content security policies. These comments improve clarity for future developers and ensure proper implementation guidelines.
suddenlyGiovanni
temporarily deployed
to
review
GitHub Actions
Inactive
Replace custom document and main components with shared layout utilities. This reduces redundancy and ensures consistency across the app by relying on a centralized layout structure. Related files `document.tsx` and `main.tsx` were removed as they are no longer needed.
suddenlyGiovanni
temporarily deployed
to
review
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes across multiple files to improve code consistency and readability. The most important changes involve refactoring components to remove unnecessary hooks and memoization, and updating imports for better type management.
Refactoring components:
apps/web/src/shell/header.tsx: Refactored theHeadercomponent to remove thememoanduseCallbackhooks, and directly define thehandleMobileNavigationClickfunction. Simplified the rendering of list items by moving theroutes.maplogic directly into the JSX. [1] [2] [3]packages/ui/src/components/mode-toggle/mode-toggle.tsx: Refactored theModeTogglecomponent to remove thememoanduseMemohooks, and replaced them with straightforward logic. Introduced amakeToggleHandlerfunction to handle theme changes more cleanly. [1] [2] [3]Updating imports:
apps/web/src/root.tsx: Added theuseRouteLoaderDataimport to replaceuseLoaderDatafor better type safety and data handling. [1] [2]apps/web/src/shell/header.tsx: Adjusted the import statement to remove unnecessarymemoanduseCallbackimports.packages/ui/src/components/mode-toggle/mode-toggle.tsx: Updated the import statement to replacememoanduseMemowithFCandMouseEventHandlerfor better type management.