Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update import paths and enhance configuration #1118

Merged
merged 3 commits into from
Dec 14, 2024
Merged

update import paths and enhance configuration #1118

merged 3 commits into from
Dec 14, 2024

Conversation

suddenlyGiovanni
Copy link
Owner

@suddenlyGiovanni suddenlyGiovanni commented Dec 14, 2024 •
edited
Loading

  • Remove vite-tsconfig-paths dependency.
  • Replace relative paths with alias syntax.
  • Streamline component usage with new import aliases.

@suddenlyGiovanni
refactor(ui): update import paths to use alias syntax
7aaeff7 
Replaced relative paths with alias-based imports for consistency and
clarity. Introduced new import aliases in configuration to streamline
 component usage and ensure maintainability.
@suddenlyGiovanni
refactor(ui): remove vite-tsconfig-paths dependency
fcbc746 
Removed the vite-tsconfig-paths plugin and its configurations from
Vite. Updated `tsconfig.json` to reflect the new inclusion paths.
Cleaned up unnecessary metadata and deprecated warnings from
pnpm-lock.yaml.
@suddenlyGiovanni
fix(web): update tsconfig include paths
95ce66a 
Removed `postcss.config.mjs` from the include paths in `tsconfig
.json`. This ensures unnecessary files are excluded from the
TypeScript compilation process.
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 14, 2024

⚠️ No Changeset found

Latest commit: 95ce66a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot]
github-actions bot reviewed Dec 14, 2024
View reviewed changes
pnpm-lock.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[misspell] reported by reviewdog 🐶
"optimise" is a misspelling of "optimize"

suddenlygiovanni.dev/pnpm-lock.yaml

Line 435 in 95ce66a

'@babel/[email protected]':

github-actions[bot]
github-actions bot reviewed Dec 14, 2024
View reviewed changes
pnpm-lock.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[misspell] reported by reviewdog 🐶
"optimise" is a misspelling of "optimize"

suddenlygiovanni.dev/pnpm-lock.yaml

Line 439 in 95ce66a

'@babel/[email protected]':

github-actions[bot]
github-actions bot reviewed Dec 14, 2024
View reviewed changes
pnpm-lock.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[misspell] reported by reviewdog 🐶
"optimise" is a misspelling of "optimize"

suddenlygiovanni.dev/pnpm-lock.yaml

Line 5760 in 95ce66a

'@babel/helper-optimise-call-expression': 7.22.5

github-actions[bot]
github-actions bot reviewed Dec 14, 2024
View reviewed changes
pnpm-lock.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[misspell] reported by reviewdog 🐶
"optimise" is a misspelling of "optimize"

suddenlygiovanni.dev/pnpm-lock.yaml

Line 5771 in 95ce66a

'@babel/helper-optimise-call-expression': 7.25.9

github-actions[bot]
github-actions bot reviewed Dec 14, 2024
View reviewed changes
pnpm-lock.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[misspell] reported by reviewdog 🐶
"optimise" is a misspelling of "optimize"

suddenlygiovanni.dev/pnpm-lock.yaml

Line 5813 in 95ce66a

'@babel/[email protected]':

github-actions[bot]
github-actions bot reviewed Dec 14, 2024
View reviewed changes
pnpm-lock.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[misspell] reported by reviewdog 🐶
"optimise" is a misspelling of "optimize"

suddenlygiovanni.dev/pnpm-lock.yaml

Line 5817 in 95ce66a

'@babel/[email protected]':

github-actions[bot]
github-actions bot reviewed Dec 14, 2024
View reviewed changes
pnpm-lock.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[misspell] reported by reviewdog 🐶
"optimise" is a misspelling of "optimize"

suddenlygiovanni.dev/pnpm-lock.yaml

Line 5830 in 95ce66a

'@babel/helper-optimise-call-expression': 7.22.5

github-actions[bot]
github-actions bot reviewed Dec 14, 2024
View reviewed changes
pnpm-lock.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[misspell] reported by reviewdog 🐶
"optimise" is a misspelling of "optimize"

suddenlygiovanni.dev/pnpm-lock.yaml

Line 5836 in 95ce66a

'@babel/helper-optimise-call-expression': 7.25.9

Copilot
Copilot AI reviewed Dec 14, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 31 out of 46 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • apps/web/tsconfig.json: Language not supported
  • packages/ui/components.json: Language not supported
  • packages/ui/package.json: Language not supported
  • packages/ui/src/components/layout/layout.tsx: Evaluated as low risk
  • packages/ui/src/components/badge/badge.stories.tsx: Evaluated as low risk
  • packages/ui/src/components/button/button.stories.tsx: Evaluated as low risk
  • packages/ui/src/components/card/card.stories.tsx: Evaluated as low risk
  • packages/ui/src/components/dropdown-menu/dropdown-menu.stories.tsx: Evaluated as low risk
  • packages/ui/src/components/typography/blockquote.tsx: Evaluated as low risk
  • packages/ui/src/components/typography/a.tsx: Evaluated as low risk
  • packages/ui/src/components/social/social.tsx: Evaluated as low risk
  • packages/ui/src/components/navigation-menu-toggle/navigation-menu-toggle.tsx: Evaluated as low risk
  • packages/ui/src/components/accordion/accordion.stories.tsx: Evaluated as low risk
  • packages/ui/src/components/collapsible/collapsible.stories.tsx: Evaluated as low risk
  • packages/ui/src/components/suddenly-giovanni/suddenly-giovanni.tsx: Evaluated as low risk
@suddenlyGiovanni suddenlyGiovanni merged commit cbde57a into main Dec 14, 2024
19 checks passed
@suddenlyGiovanni suddenlyGiovanni deleted the internal/node-path branch December 14, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@suddenlyGiovanni