Ci/biome checks #1092

suddenlyGiovanni · 2024-12-07T00:58:51Z

No description provided.

Remove deprecated warnings for 'glob' and 'inflight' modules from the pnpm-lock.yaml file. The 'glob' warning was related to unsupported versions before v9, and the 'inflight' module warning mentioned potential memory leaks. Signed-off-by: suddenlyGiovanni <[email protected]>

Lowering the Node.js engine version ensures compatibility with environments that only support Node.js version 22.10. This change affects multiple modules including web, open-graph-protocol, root, and ui packages. Signed-off-by: suddenlyGiovanni <[email protected]>

Replace the existing linter command with a more robust Biome setup. This change ensures proper code checks, organizes imports, and automatically handles changes. The shell setting and additional Biome options enhance compatibility and functionality. Signed-off-by: suddenlyGiovanni <[email protected]>

Streamline the biome configuration by eliminating specific overrides and linter rules that were previously set. This change enhances maintainability and reduces complexity by relying on the default settings defined in the parent configuration. Additionally, update file ignore patterns to include `.react-router`. Signed-off-by: suddenlyGiovanni <[email protected]>

Introduce a new biome.json configuration file for the TypeScript module. This configuration extends the base settings and specifies which JSON files to include. It also enables the JSON formatter for better code consistency. Signed-off-by: suddenlyGiovanni <[email protected]>

Update biome.json to enhance linter and formatter settings, including enabling 'useEditorconfig' and revising linter rules. Make `getEnv` typing more consistent by renaming type `ENV` to `Env`. Additionally, address naming convention warnings in env.server.ts with biome-ignore comments. Signed-off-by: suddenlyGiovanni <[email protected]>

Disabled noUndeclaredDependencies rule for correctness. Updated import to use destructuring for process.env. Added a lint ignore comment for naming conventions in octokit service. Signed-off-by: suddenlyGiovanni <[email protected]>

Refactor theme switch to use a simplified conditional return in the header module. Add comments to manually suppress lint warnings related to naming conventions and assertions across multiple files for improved code clarity and maintainability. Signed-off-by: suddenlyGiovanni <[email protected]>

Add explicit return types to functions to improve type safety and readability across the codebase. Incorporate several new lint rules in the `biome.json` configuration to enhance code consistency and maintainability. These changes will help prevent potential errors and align with best practices. Signed-off-by: suddenlyGiovanni <[email protected]>

Add explicit type annotations and improve the theme mode computation in the header component for better code clarity. Refactor import statements across multiple routes for consistency and adherence to new linting rules. Adjust biome configuration to ignore certain specific lint warnings. Signed-off-by: suddenlyGiovanni <[email protected]>

Improve type definitions across multiple modules for better type safety. Introduce biome-ignore comments to manage import linting issues, ensuring cleaner and more maintainable code. These changes enhance overall code robustness and adherence to specified linting standards. Signed-off-by: suddenlyGiovanni <[email protected]>

Eliminate unnecessary aria-label and role attributes to streamline the code. These attributes do not contribute to accessibility or functionality in their current context. This change enhances code readability and maintainability without affecting user experience. Signed-off-by: suddenlyGiovanni <[email protected]>

Enhance biome configurations by adding new lint rules. Ignored `noNamespaceImport` lint rule in `switch.tsx` and `utils.ts` to prevent unnecessary warnings. Signed-off-by: suddenlyGiovanni <[email protected]>

Include maximum diagnostic and modify vcs-root for consistency. Removed the unnecessary period from the write argument for better command execution. Signed-off-by: suddenlyGiovanni <[email protected]>

Consolidate utility imports into a single index.ts file in the utils directory for improved maintainability and readability. Update all necessary import statements across the open-graph-protocol package accordingly. Adjust biome.json to reflect the naming convention changes. Signed-off-by: suddenlyGiovanni <[email protected]>

changeset-bot · 2024-12-07T00:58:55Z

⚠️ No Changeset found

Latest commit: 1c1252b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2024-12-07T00:59:20Z

pnpm-lock.yaml

[misspell] _{reported by reviewdog 🐶}
"optimise" is a misspelling of "optimize"

suddenlygiovanni.dev/pnpm-lock.yaml

Line 358 in 509e1b6

'@babel/[email protected]':

github-actions · 2024-12-07T00:59:22Z

pnpm-lock.yaml

[misspell] _{reported by reviewdog 🐶}
"optimise" is a misspelling of "optimize"

suddenlygiovanni.dev/pnpm-lock.yaml

Line 4882 in 509e1b6

'@babel/helper-optimise-call-expression': 7.22.5

github-actions · 2024-12-07T00:59:23Z

pnpm-lock.yaml

[misspell] _{reported by reviewdog 🐶}
"optimise" is a misspelling of "optimize"

suddenlygiovanni.dev/pnpm-lock.yaml

Line 4915 in 509e1b6

'@babel/[email protected]':

github-actions · 2024-12-07T00:59:23Z

pnpm-lock.yaml

[misspell] _{reported by reviewdog 🐶}
"optimise" is a misspelling of "optimize"

suddenlygiovanni.dev/pnpm-lock.yaml

Line 4926 in 509e1b6

'@babel/helper-optimise-call-expression': 7.22.5

codecov-commenter · 2024-12-07T00:59:54Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@42ca943). Learn more about missing BASE report.

Additional details and impacted files

@@          Coverage Diff           @@
##             main   #1092   +/-   ##
======================================
  Coverage        ?   3.53%           
======================================
  Files           ?      41           
  Lines           ?    2462           
  Branches        ?      44           
======================================
  Hits            ?      87           
  Misses          ?    2375           
  Partials        ?       0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Clean up a function by removing unnecessary whitespace after the return keyword. This ensures code consistency and adheres to style guidelines. No functional change has been made. Signed-off-by: suddenlyGiovanni <[email protected]>

Updated the code formatting step in the push-checks-workflow to use the Biome tool for consistent formatting checks. This change ensures proper diagnostics and organized imports while adapting to VCS settings. Signed-off-by: suddenlyGiovanni <[email protected]>

Remove unnecessary format and lint script variants from various package configuration files to streamline build processes. These changes simplify the scripts section, reducing maintenance overhead and potential redundancy across modules. Signed-off-by: suddenlyGiovanni <[email protected]>

Revise the code formatting and linting steps in the pull request checks workflow. Use `biome ci` with specific settings for better control and reporting in GitHub. Adjust the commands to enhance compatibility and streamline the code quality checks. Signed-off-by: suddenlyGiovanni <[email protected]>

Simplify package.json by removing unnecessary format:ci and lint:ci scripts across modules. These changes reduce redundancy and potential maintenance overhead. All affected modules have been updated to reflect this change. Signed-off-by: suddenlyGiovanni <[email protected]>

Fix syntax error by adding missing backslashes to command lines in the pull-request-checks-workflow.yml to ensure proper execution. This change enables correct execution of the defined commands for continuous integration. Signed-off-by: suddenlyGiovanni <[email protected]>

suddenlyGiovanni added 15 commits December 7, 2024 01:57

fix(biome): update lint rules and imports usage

d116640

Disabled noUndeclaredDependencies rule for correctness. Updated import to use destructuring for process.env. Added a lint ignore comment for naming conventions in octokit service. Signed-off-by: suddenlyGiovanni <[email protected]>

feat(ui): update biome config and ignore lint rules

e2c835c

Enhance biome configurations by adding new lint rules. Ignored `noNamespaceImport` lint rule in `switch.tsx` and `utils.ts` to prevent unnecessary warnings. Signed-off-by: suddenlyGiovanni <[email protected]>

fix(workflow): adjust Biome check command options

9f8cc2f

Include maximum diagnostic and modify vcs-root for consistency. Removed the unnecessary period from the write argument for better command execution. Signed-off-by: suddenlyGiovanni <[email protected]>

suddenlyGiovanni temporarily deployed to review December 7, 2024 00:58 — with GitHub Actions Inactive

github-actions bot reviewed Dec 7, 2024

View reviewed changes

suddenlyGiovanni added 2 commits December 7, 2024 02:10

suddenlyGiovanni temporarily deployed to review December 7, 2024 01:12 — with GitHub Actions Inactive

suddenlyGiovanni temporarily deployed to review December 7, 2024 01:17 — with GitHub Actions Inactive

suddenlyGiovanni temporarily deployed to review December 7, 2024 01:24 — with GitHub Actions Inactive

suddenlyGiovanni deployed to review December 7, 2024 01:29 — with GitHub Actions View deployment

suddenlyGiovanni merged commit fd30f63 into main Dec 7, 2024
16 of 18 checks passed

suddenlyGiovanni deleted the ci/biome-checks branch December 7, 2024 01:33

suddenlyGiovanni temporarily deployed to review December 7, 2024 01:33 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ci/biome checks #1092

Ci/biome checks #1092

suddenlyGiovanni commented Dec 7, 2024

changeset-bot bot commented Dec 7, 2024 •

edited

Loading

github-actions bot Dec 7, 2024

github-actions bot Dec 7, 2024

github-actions bot Dec 7, 2024

github-actions bot Dec 7, 2024

codecov-commenter commented Dec 7, 2024

Ci/biome checks #1092

Ci/biome checks #1092

Conversation

suddenlyGiovanni commented Dec 7, 2024

changeset-bot bot commented Dec 7, 2024 • edited Loading

⚠️ No Changeset found

github-actions bot Dec 7, 2024

Choose a reason for hiding this comment

github-actions bot Dec 7, 2024

Choose a reason for hiding this comment

github-actions bot Dec 7, 2024

Choose a reason for hiding this comment

github-actions bot Dec 7, 2024

Choose a reason for hiding this comment

codecov-commenter commented Dec 7, 2024

Codecov Report

changeset-bot bot commented Dec 7, 2024 •

edited

Loading