Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handles to playlist sort tracks #789

Merged
merged 18 commits into from
Sep 27, 2019
Merged

Conversation

ofsound
Copy link
Collaborator

@ofsound ofsound commented Sep 26, 2019

Fixes #764

I used CSS to change what can be clicked on within a track asset, and to change out the graphics for our new handles.

Bugs

  • Something is up with Safari, not sure if it's related to the handles, but I get only every other drag attempt to work! — looks like it's that you can't re-drag on Safari 13, bug is here: Safari 13 loses drag event SortableJS/Sortable#1571
  • FF and Chrome on MacOS appear happy over here
  • Mobile Chrome and Safari, the handles and dragging appear to work fine, but the ghosts and final sorting I'm not sure are working!
  • confirm reorder spec is happy

Open needs

  • Handles need to show up on percy and aren't yet
  • green checkmark shows up next to "saved" on percy
  • Add mini-handle svg into the instructions and edit it to read "Reorder your playlist by dragging your tracks by the ||| icon. Remove them from the playlist with the X icon."

@ofsound ofsound requested a review from sudara September 26, 2019 20:53
@sudara
Copy link
Owner

sudara commented Sep 27, 2019

It turns out the playlist reordering spec was working on master https://percy.io/alonetone/alonetone/builds/2671620

However there was no flash alert...

@sudara
Copy link
Owner

sudara commented Sep 27, 2019

@ofsound I think this just needs another round of QAtune and that mini icon put into place...

@sudara sudara marked this pull request as ready for review September 27, 2019 21:47
@sudara sudara merged commit 5141a2c into master Sep 27, 2019
@sudara sudara deleted the add_handles_to_playlist_sort_tracks branch September 27, 2019 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove play button and add handle for playlist sortable on mobile
2 participants