Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust display of data with long strings and emojis #1139

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

ofsound
Copy link
Collaborator

@ofsound ofsound commented Sep 20, 2021

I don't think this resolves any of our official issues!!

Mainly it addresses some overflow bugs with emoji characters that are taller than any of a font's regular characters, in accordions and in the mini "listens" module.

It also fixes a few cases of when a very long artist name would take up 2 vertical lines in areas where the design didn't intend for that to happen.

I also added some horizontal padding in a few places I had noticed where a long artist name could push a field to be 100% and inappropriately extend to the very edge of its container.

"Ready For Review" checklist

These checklists are to help ensure the code review basics are covered. Consider removing to reduce noise.

  • PR title accurately summarizes changes
  • New tests were added for isolated methods or new endpoints
  • I opened an issue for any logical followups
  • If this fixes a bug, "Fixes #XXX" is either the very first or very last line of the description.

Before code review and after additional commits during review.

  • Update title and description to account for additional changes
  • All tests green
  • Migrations were tested locally and do the right thing
  • Booted up the branch locally, exercised any new code
  • Percy changes are purposeful or explained
  • Css changes are happy on mobile (via Percy is ok)

@ofsound ofsound changed the title Adjust line-heights throughout for Emoji use in Track and Playlist titles, also handle very long names/titles Adjust display of data with long strings and emojis Sep 20, 2021
@ofsound ofsound marked this pull request as ready for review September 28, 2021 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant