Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lockfile cleanup #1763

Merged
merged 2 commits into from
Nov 6, 2024
Merged

chore: lockfile cleanup #1763

merged 2 commits into from
Nov 6, 2024

Conversation

umadayal
Copy link
Contributor

@umadayal umadayal commented Nov 6, 2024

Removes the Cargo.lock files in some of the tests that were accidentally added with the secp256r1 commit along with the merkle_tree.bin file. Updated examples since the ECDSA signatures patch was updated to take in a specific commit instead of branch

Copy link
Member

@ratankaliani ratankaliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@umadayal umadayal changed the title fix: delete Cargo.lock files in dev and merkle_tree.bin fix: cleaned up Cargo.lock files Nov 6, 2024
@ratankaliani ratankaliani changed the title fix: cleaned up Cargo.lock files fix: lockfile cleanup Nov 6, 2024
@ratankaliani ratankaliani changed the title fix: lockfile cleanup chore: lockfile cleanup Nov 6, 2024
Copy link

github-actions bot commented Nov 6, 2024

SP1 Performance Test Results

Branch: umadayal/dev-fixes
Commit: 34bdda0
Author: umadayal

program cycles execute (mHz) core (kHZ) compress (KHz) time success
fibonacci 11291 0.16 2.82 0.47 24s
ssz-withdrawals 2757356 16.39 126.49 35.04 1m19s
tendermint 12593597 6.76 267.59 98.50 2m10s

@umadayal umadayal merged commit c804db2 into dev Nov 6, 2024
15 checks passed
@umadayal umadayal deleted the umadayal/dev-fixes branch November 6, 2024 21:07
yuwen01 pushed a commit that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants