Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lower precision time/date types. #22

Merged
merged 3 commits into from
Sep 10, 2021
Merged

Remove lower precision time/date types. #22

merged 3 commits into from
Sep 10, 2021

Conversation

jacques-n
Copy link
Contributor

@jacques-n jacques-n commented Sep 9, 2021 •
edited
Loading

Also correct duplicated decimal line.

This change is Reviewable

westonpace
westonpace previously approved these changes Sep 9, 2021
View reviewed changes
Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

site/docs/types/compound_logical_types.md Outdated Show resolved Hide resolved
@jacques-n jacques-n merged commit 3ff938d into substrait-io:main Sep 10, 2021
@jacques-n jacques-n deleted the remove_milli_precision branch September 17, 2021 20:51
rkondakov pushed a commit to rkondakov/substrait that referenced this pull request Nov 21, 2023
Implement POJO plan object (substrait-io#22)
001d401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emkornfield emkornfield Awaiting requested review from emkornfield

@westonpace westonpace Awaiting requested review from westonpace westonpace is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacques-n @westonpace