Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps)!: upgrade prost to 0.13 for hyper 1.x #195

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

tisonkun
Copy link
Contributor

@tisonkun tisonkun commented Jul 8, 2024

tonic 0.12 depends on prost 0.13

tonic 0.12 depends on prost 0.13
@westonpace
Copy link
Member

Hmm...looks like some failures with pbjson. Want to open an issue at https://github.com/influxdata/pbjson ? Looks like @tustvold is maintainer so maybe can trade some arrow/df favors 😆

@tisonkun
Copy link
Contributor Author

tisonkun commented Jul 8, 2024

Yeah. This is a deep dependency tree .. I arrive here from upgrading GreptimeDB's tonic version and it depends on datafusion -> substratit and now pbjson ..

@tisonkun
Copy link
Contributor Author

tisonkun commented Jul 8, 2024

So here it is - influxdata/pbjson#126

The upstream needs to make a release also .. So perhaps take some time.

@tustvold
Copy link

tustvold commented Jul 8, 2024

Looks like @tustvold is maintainer so maybe can trade some arrow/df favors

I'm afraid I no longer work at influxdata, but @alamb can probably be persuaded to take a look

@alamb
Copy link

alamb commented Jul 8, 2024

So here it is - influxdata/pbjson#126

The upstream needs to make a release also .. So perhaps take some time.

I'll take care of it

@alamb
Copy link

alamb commented Jul 8, 2024

So here it is - influxdata/pbjson#126

The upstream needs to make a release also .. So perhaps take some time.

I merged influxdata/pbjson#126 and am tracking the release of the next version via influxdata/pbjson#127

@mbrobbel mbrobbel changed the title build(deps): upgrade prost to 0.13 for hyper 1.x build(deps)!: upgrade prost to 0.13 for hyper 1.x Jul 9, 2024
@mbrobbel mbrobbel merged commit 16ead96 into substrait-io:main Jul 9, 2024
13 checks passed
@tisonkun tisonkun deleted the patch-2 branch July 9, 2024 15:06
@alamb
Copy link

alamb commented Jul 9, 2024

Update here is that pbjson 0.7.0 was released and influxdata/pbjson#127 is done so I think that should unblock some more of the dependency upgrades

Looks like we next need to get arrow-flight 👓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants