feat: Add expression wrapper to ExprBuilder #73
Conversation
…cts as function arguments.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
=======================================
Coverage 58.28% 58.28%
=======================================
Files 43 43
Lines 9130 9132 +2
=======================================
+ Hits 5321 5323 +2
Misses 3565 3565
Partials 244 244 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
expr/builder_test.go
Outdated
| @@ -17,6 +17,7 @@ func TestExprBuilder(t *testing.T) { | |||
| Reg: expr.NewEmptyExtensionRegistry(&extensions.DefaultCollection), | |||
| BaseSchema: &boringSchema.Struct, | |||
| } | |||
| precomputedExpression, _ := expr.NewLiteral(int32(3), false) | |||
There was a problem hiding this comment.
should we use examples that aren't Literals since wrap methods and such for literals, such as using the builder to create an expression first and then using that expression later, etc.
There was a problem hiding this comment.
I was pondering merging Wrap and WrapExpression into Wrap (with the functionality of WrapExpression) since they are essentially the same.
I will also add a non-literal Expression example.
|
Looks great, thanks @EpsilonPrime! |
This will allow previously calcuated Expression objects to be used as function arguments.