chore: skip c tests if env var is present #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jacques-n
previously approved these changes
Jan 10, 2025
100% agree. It appears this is the first/only extension that has C tests so is the first one that needs C headers present. I am sure there is a way to tell cmake to change where it looks for include files or do some symlinking but its beyond my cmake skills so wanted to defer until I am more comfortable w cmake |
rymurr
changed the title
anshuldata
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While integrating this extension as an out of tree extension using https://github.com/duckdb/duckdb/tree/main/extension#remote-github-repo and building duckdb I found that the C tests don't compile properly: the submodules aren't checked out in this path.
This was the simplest and cleanest way I could find to skip the compilation of the C tests when compiling substrait directly in duckdb (these tests aren't run in that path anyways and the tests still are run as part of normal CI)