Skip to content

Commit

Permalink
Fix: Update duckdb to get Latest Relation Definition (#122)
Browse files Browse the repository at this point in the history
* Update duckdb to get Latest Relation
* Update Workflow definition to use fix commit for duckdb submodule
* Fix extension code required because of update of duckdb

* Exclude "windows_amd64_rtools" from archs
  • Loading branch information
anshuldata authored Nov 13, 2024
1 parent 82bad97 commit 6ae6557
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/main_distribution.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ jobs:
name: Build extension binaries
uses: duckdb/extension-ci-tools/.github/workflows/_extension_distribution.yml@main
with:
duckdb_version: main
ci_tools_version: main
exclude_archs: "wasm_mvp;wasm_eh;wasm_threads;windows_amd64;windows_amd64_mingw"
duckdb_version: ca5af32c331f9d5ea49f7158d5c83a47f25b8b79
ci_tools_version: 5bdbe4d606d78dbd749f9578ba8ca639feece023
exclude_archs: "wasm_mvp;wasm_eh;wasm_threads;windows_amd64;windows_amd64_mingw;windows_amd64_rtools"
extension_name: substrait

2 changes: 1 addition & 1 deletion duckdb
Submodule duckdb updated 292 files
2 changes: 1 addition & 1 deletion src/to_substrait.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1317,7 +1317,7 @@ substrait::Rel *DuckDBToSubstrait::TransformGet(LogicalOperator &dop) {
auto &column_ids = dget.GetColumnIds();
for (auto col_idx : dget.projection_ids) {
auto struct_item = select->add_struct_items();
struct_item->set_field(static_cast<int32_t>(column_ids[col_idx]));
struct_item->set_field(static_cast<int32_t>(column_ids[col_idx].GetPrimaryIndex()));
// FIXME do we need to set the child? if yes, to what?
}
projection->set_allocated_select(select);
Expand Down

0 comments on commit 6ae6557

Please sign in to comment.