FPA M0.5: Onsite Preview updates #3555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristenwang
approved these changes
Sep 3, 2024
justinchou-google
requested review from
ChrisAntaki,
jpettitt,
oyj9109 and
Wayne-X
as code owners
justinchou-google
changed the title
oyj9109
reviewed
Sep 3, 2024
oyj9109
approved these changes
Sep 3, 2024
kristenwang
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/362347951
Updates onsite preview to use contentType to determine closability for FPA M0.5.
Also cleans up onsite preview experiment rampup flags, fixes some dead references, and adds a TODO (b/364344782) to revisit this logic with new PM for M1+.