Render preview for regwall, newsletter and survey prompts #3530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristenwang
requested review from
ChrisAntaki,
jpettitt,
justinchou-google,
oyj9109 and
Wayne-X
as code owners
oyj9109
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interaction is disabled when interacting with regwall, newsletter and survey prompts:
https://screencast.googleplex.com/cast/NDgyMjk2NjA5MjE2OTIxNnw3YzVhZjBlMy1iNg
This is the initial GA requirements for preview prompts, see meeting notes: https://docs.google.com/document/d/1nKszFDK1yh6gdIrsXZfL5cxrbsuNKDJhrNmN6iNKRKc/edit?resourcekey=0-lS48WOcp33v5-9AeEuvZVA&tab=t.0#heading=h.g2mtcg3lwi4u
With interaction disabled, we don't need to worry about completion & google sign in flow or the survey data transfer for now.