Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rewarded ad loading/bailout flow #3460

Merged
merged 8 commits into from
Mar 27, 2024

Conversation

mhkawano
Copy link
Contributor

@mhkawano mhkawano commented Mar 15, 2024

This introduces three related changes, and are bundled as one so that I can test them together.

  1. We will not show anything until we've confirmed that a rewarded ad can be shown, effectively removing the loading view.
  2. We will not block a rewarded ad user if they cannot show the prompt, and do not have an alternative action.
  3. We will pass locked to the article endpoint based on the page config.

b/328640563
b/328639440
b/328640557

@mhkawano mhkawano changed the title Don't lock the page for rewarded ads until we're sure we can an ad. Update rewarded ad loading/bailout flow Mar 15, 2024
@mhkawano mhkawano marked this pull request as ready for review March 25, 2024 14:52
@mhkawano mhkawano merged commit 87c49cd into subscriptions-project:main Mar 27, 2024
7 checks passed
@mhkawano mhkawano deleted the delay_loading branch March 27, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants