Escape publisher provided strings #3436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhkawano
requested review from
ChrisAntaki,
jpettitt,
justinchou-google,
oyj9109 and
Wayne-X
as code owners
| const BAD_CONFIG = ` | ||
| { | ||
| "publication": { | ||
| "name": "<script>PUBLICATOIN_NAME</script>" |
There was a problem hiding this comment.
nit: PUBLICATION_NAME (my understanding is the html is what makes it a bad input and not the typo, correct me if i'm wrong)
There was a problem hiding this comment.
Fixed, thanks.
Yes, we want to escape any potentially malicious strings.
| @@ -27,6 +27,7 @@ | |||
| "build-storybook": "build-storybook" | |||
| }, | |||
| "dependencies": { | |||
| "safevalues": "0.5.2", | |||
There was a problem hiding this comment.
not sure what our policy is on using external libraries... @oyj9109 @ChrisAntaki do you know?
There was a problem hiding this comment.
We've really tried avoiding it when possible. That being said, this is an open library from Google. Do we know how many bytes this adds to the compiled JavaScript?
ChrisAntaki
approved these changes
Feb 22, 2024
|
Tested Firefox and Safari for polyfill. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This escapes the title, and message, both provided by the publisher. We use the safevalues library, which is an open source Google library recommended by the ISE's secure coding site.
b/326280984